In our (entity) data source controller's loadItems() method, we should remove items from tracking if they couldn't be loaded successfully. This helps to avoid problems when an entity was removed but the appropriate hooks for some reason weren't called. (It also cleans up after our previous temporary problem where entity deletes weren't correctly registered.)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1319500--deleted-items-cleanup-2.patch | 797 bytes | drunken monkey |
| #1 | 1319500--deleted-items-cleanup-1.patch | 967 bytes | drunken monkey |
Comments
Comment #1
drunken monkeyPatch attached.
Comment #2
drunken monkeySlightly cleaner way to do this.
Comment #3
mh86 commentedAdding this check is probably a good idea, and it doesn't hurt if everything is fine.
Comment #4
drunken monkeyGreat, committed.