Activity comments disappear [#1314284]

When I add a heartbeat comment to an activity that was created with the shoutbox the comment disappears after some time (about 24 hours one day) it is also deleted from the database table. I cannot figure out when exactly the comment gets removed from the table and why.

Is there any configuration which causes comments to be deleted after a given time? Does the standard cron job do anything on the heartbeat comments table?

Thanks in advance for your support

Comments

Comment #1

Stalski CreditAttribution: Stalski commented 19 October 2011 at 11:58

Comments are actually only deleted when the parent activity message (or in node context, the node) gets deleted.

The cronjob will delete too old activity (and their comments attached).

So I don't know of any case where comments would be deleted with the parent activity being deleted. Not sure what could cause this behavior.

Comment #2

goekhanc CreditAttribution: goekhanc commented 21 October 2011 at 21:23

Do you have any hint, how I can trace what causes this problem?

I am trying to analyze mysql.log but cannot find where the comments are removed.

Comment #3

Stalski CreditAttribution: Stalski commented 22 October 2011 at 19:47

The best solution to find the problem is to see inside the comment delete function (I do hope you mean node comments) and do a ddebugbactrace or debug_backtrace if you don't have devel installed.

Comment #4

goekhanc CreditAttribution: goekhanc commented 22 October 2011 at 21:45

"Enable node comments for this activity template if a node is available " is not enabled. all acitivty comments are not node comments. even though the activity is "node creation". the comments are stored in the heartbeat_comments.

Comment #5

Stalski CreditAttribution: Stalski commented 22 October 2011 at 21:47

ok, then you'll need to backtrace in the heartbeat comment delete function

Comment #6

goekhanc CreditAttribution: goekhanc commented 23 October 2011 at 13:56

I noticed, that activity comments get removed, after I remove an activity. I dont mean, that the related comment disappears, but all activity comments disappear.

Maybe these lines in the mysql.log cause this???

                  633 Query     DELETE FROM netsiad_heartbeat_activity
WHERE  (uaid IN  ('2131'))
                  633 Query     DELETE FROM netsiad_heartbeat_comments
WHERE  (uaid)

Comment #7

goekhanc CreditAttribution: goekhanc commented 23 October 2011 at 19:51

I commented the comments delete function, which is called after an activity has been deleted. The acitivity comments are not removed after one activity is deleted. But now every comments will be kept in the table, even though the corresponding activity is deleted.

It seems to me that there is a problem with the $uaids variable. But I dont know how to solve this problem.

my change in heartbeat_comments.module

 186 function heartbeat_comments_heartbeat_activity_delete($uaids) {
 187 //  db_delete('heartbeat_comments')->where('uaid', $uaids, 'IN')->execute();
 188 }
 189

Comment #8

Stalski CreditAttribution: Stalski commented 16 February 2012 at 19:32

DELETE FROM netsiad_heartbeat_comments
WHERE (uaid)

This is indeed the error, this should not happen.

So in detail:

function heartbeat_comments_heartbeat_activity_delete($uaids) {
  db_delete('heartbeat_comments')->where('uaid', $uaids, 'IN')->execute();
}

This was the function and this is how it is now:

function heartbeat_comments_heartbeat_activity_delete($uaids) {
  if (!empty($uaids)) {
    db_delete('heartbeat_comments')->condition('uaid', $uaids, 'IN')->execute();
  }
}

So this will fix the problem. I used where and it should be condition. In all other places, I used it correct, stupid :(

So thanks for the report and the fix has been pushed to git.