This one might need some explanation though. ;)

We, as a collective, had issues with @fago's usual way of "over-abstraction" in the past. However, this concern was communicated, and he welcomed the feedback and even started to "simplify" some stuff in contrib already.

At this point, partially due to entity.module in contrib, @fago is probably the most experienced API developer in the entity system field.

His recent replies in the core queue attest that. (like #1042822-46: Developers need an $entity->entity_type property)

CommentFileSizeAuthor
#9 d7_entity.patch416 bytesfago
drupal8.entity-fago-maintainer.0.patch365 bytessun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago’s picture

We, as a collective, had issues with @fago's usual way of "over-abstraction" in the past. However, this concern was communicated, and he welcomed the feedback and even started to "simplify" some stuff in contrib already.

lol - yep, that sort of feedback is invaluable!

I'll continue working on the entity API and moving it forward while making sure it works for developers. So yep, I'd be happy to help out as maintainer!

yched’s picture

Status: Needs review » Reviewed & tested by the community

Sounds only logical.

webchick’s picture

Does this need backport to D7 too? :)

Lars Toomre’s picture

Only if this meets the D7 coding standards webchick. Now where were those documented? LOL :)

webchick’s picture

??

Right here: http://drupal.org/coding-standards

If people want to add D8-only rules to the coding standards, it's fine with me, and up to them to document them as such. :)

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs review

Committed and pushed to 8.x.

Moving CNR for 7.x, not sure if fago volunteered for that too or not ;)

fago’s picture

Yay :)

@d7: Yep, I'd be happy to cover d7 too.

webchick’s picture

Status: Needs review » Patch (to be ported)

yay. :)

fago’s picture

Status: Patch (to be ported) » Needs review
FileSize
416 bytes

Re-rolled patch for d7 to apply without fuzz.

Status: Needs review » Needs work

The last submitted patch, d7_entity.patch, failed testing.

tstoeckler’s picture

Status: Needs work » Needs review

#9: d7_entity.patch queued for re-testing.

amateescu’s picture

Status: Needs review » Reviewed & tested by the community

Hey, how did we forget about this? :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Woohoo! :) Committed and pushed to 7.x. Thanks!

fago’s picture

Oh, I had forgotten that it's still open for D7 too. :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.