Could you add a setting to disable breadcrumbs? With a back button and home button in the header, i dont see the need for breadcrumbs on a mobile site but if there was a setting to turn on or off... that would be a simple yet helpful feature.

CommentFileSizeAuthor
#2 mobile_jquery-breadcrumbs-1306534-2.patch3.24 KBjeffschuler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jasonsavino’s picture

jasonsavino CreditAttribution: jasonsavino commented

good suggestion.
If you would like to patch it please feel free otherwise, I will work on it as soon as I can.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented
Status: Active » Needs review
FileSize
mobile_jquery-breadcrumbs-1306534-2.patch3.24 KB

Here's a patch that makes a theme setting for enabling/disabling breadcrumbs.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented
Version: 7.x-1.1-beta1 » 7.x-1.x-dev

Patch against 7.x-1.x-dev.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented
Title: More theme settings » Theme setting to disable breadcrumbs

More specific title.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented

[edit] removed, sorry.

jasonsavino’s picture

jasonsavino CreditAttribution: jasonsavino commented
Status: Needs review » Closed (won't fix)

After much consideration I feel that, as with the back button issue, this is best kept out of the theme settings. It is recommended that you simply remove the breadcrumb code from the tpl.

quiptime’s picture

quiptime CreditAttribution: quiptime commented
Priority: Normal » Major
Status: Closed (won't fix) » Active

It is recommended that you simply remove the breadcrumb code from the tpl

Jason, if won't fix the last word?

If it is so, I must say it's a stupid decision.

Excuse me for my words. But, many themes use this UI feature (see patch #2). I can not see a rational reason, it makes Mobile jQuery Theme not the same.

jasonsavino’s picture

jasonsavino CreditAttribution: jasonsavino commented
Status: Active » Closed (works as designed)

quiptime, you are entitled to your opinion. Though I must point out that many theme creators have, in fact, decided NOT to put that feature. As a matter of fact, the CORE themes do not use this feature. Instead, they default to letting the themer remove the breadcrumb variable from their code if desired. I am simply choosing to follow that pattern for the time being.

IrishGringo’s picture

IrishGringo CreditAttribution: IrishGringo commented

Actually... I just removed the Breadcrumbs, and I think the results are awsome. I vote for an admin setting to remove breeadcrumb

jhr’s picture

jhr CreditAttribution: jhr commented
Priority: Major » Normal
Status: Closed (works as designed) » Needs work

Though I must point out that many theme creators have, in fact, decided NOT to put that feature. As a matter of fact, the CORE themes do not use this feature. Instead, they default to letting the themer remove the breadcrumb variable from their code if desired. I am simply choosing to follow that pattern for the time being.

So just to recap why...

You are using Bartik and/or Seven as your peers for your MOBILE theme?
AND
a presumption that theme makers actually made a decision to NOT give this option (vs not thinking of it, or just getting their theme finished)
AND
that the best option (when you have a patch sitting right there) is for people to edit a .tpl.php file and remove a variable, that will continue to be calculated, and rendered, only to be null'd/removed later.

jamesJonas’s picture

jamesJonas CreditAttribution: jamesJonas commented

Here is a module: Disable breadcrumbs. Seems to work great.

Disable Breadcrumbs

http://drupal.org/project/disable_breadcrumbs