Splitting off from #1304550: Display count of issue followers when viewing an issue so we don't delay that while we figure out this...

It'd be nice to have a page to see all the users following a given issue, ideally a grid of user pictures/usernames (see #957320: Enable the support for user profile pictures).

This page should be quite easy to build with views (a new default view provided by project_issue) and given the flag schema should result in a pretty cheap query.

In terms of the path for this page, an obvious choice would be /node/N/followers. However, we're having the same debate about the proper URL for the issue JSON callback over at #112805: JSON menu callback for project issues. Part of me is worried about URL collisions with a default view living at a path like that, and it makes more sense to do /node/N/project-issue/(followers|json|?). It's basically the same reason the default flag is called "project_issue_follow". Hrm.

CommentFileSizeAuthor
#19 Selection_034.jpeg46.26 KBkyle_mathews
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klonos’s picture

dasjo’s picture

Leeteq’s picture

Is there a separate issue dealing with +1/-1 comments somewhere?
(If people want to simply signify their support or rejection of a proposal, are they still supposed to do that through commenting?)

klonos’s picture

Yep, here you go Daniel: #42232: Help Maintainers Manage Issue Priority by Encouraging Voting

PS: ...the issue's title actually was "Allow voting on issues & comments in drupal.org - Death to "+1" comments." a while ago ;)

dww’s picture

Dane Powell’s picture

+1 - the problem with the new subscription system is that you don't know whether a given participant in an issue is still actually watching the issue. This would at least allow you to be pretty sure that any replies directed towards specific users will be seen by those users.

ksenzee’s picture

node/N/project-issue/followers seems reasonable for the path of a default view. It does seem easy. Would it be an appropriate novice issue for a new d.o contributor?

klonos’s picture

...the problem with the new subscription system is that you don't know whether a given participant in an issue is still actually watching the issue.

Good catch Dane! I actually haven't thought of this and I believe it deserves a better (more direct) way to be visible to the people reading through an issue than having to "dig" in the "followers list" page we aim to create here. I thing that perhaps a "(following)" status indication next to the usernames in each comment would be better, but then this is a whole separate issue. If people thing that this would be a huge "UI overwhelm" (also because most people posting comments are most likely to be following the issue), we can then have it the other way around: a "(not following)" indication for those that post comments but later on unsubscribe .../*cough*/ "unfollow" I mean ;)

Heine’s picture

Why should this information be public?

gdd’s picture

I don't really see the point of making this information public either. I can see where having the count of users following is useful, but the actual list seems like overkill and (maybe) a privacy violation. There may be times when I want to follow an issue without necessarily making it known, and to me this is a distinct advantage of the new Following system.

Dane Powell’s picture

It seems that the primary benefit of having such a page would be as described in #6/#8 - allowing users to know whether another given user will be notified about replies to an issue. Very valuable feature and overlooked deficiency in the new system, IMHO.

The only benefit I can see of not having such a page is allowing people to subscribe 'clandestinely' or 'anonymously' to an issue. I can't imagine there's a huge number of users interested in that. It would really be no different than before- everyone knew that you were subscribed to an issue by virtue of you having posted in it. Now they'll know because you are listed on a following page.

Personally, I prefer to maintain the status quo rather than dropping long-standing features in favor of new ones.

Heine’s picture

The "followers page" is a new feature. Current users of the feature do not know how the data is treated.

cweagans’s picture

In the past, your issue subscriptions had to be public because they were done through a comment (unless you subscribed to all issues in a project). I think that, at the very least, we should have a follower count (there's another issue for that), but I don't think there's anything wrong with providing a follower page.

gdd’s picture

I still dont see what we GAIN by having a followers list. I can think of several situations in which I might want to follow privately, especially considering the political and/or policy discussions that happen in queues like webmasters or groupsdrupalorg. If I am a webmaster and a specific user has a history of causing problems, I may want to monitor how they behave in other issues. I may start following issues in a specific queue without wanting the maintainer to realize I have interest until I'm ready to get involved. I can think of lots of reasons not to make it public, but I have yet to see anything we specifically gain from it, other than the ability to say 'Oh look webchick is following my issue'

cweagans’s picture

What about the use case where I make a comment that could use input from somebody else? I wouldn't want to bother them in IRC if they're already following the issue.

Another option is to provide this page and lock it down so only people with a given permission can see the page.

Dane Powell’s picture

@heyrocker - With all due respect, have you read ANY of my posts in this issue? I think I spell out pretty clearly why this is a needed feature. cweagans makes the same point.

I understand your privacy concerns. Would it be a good compromise to limit access to the 'followers list' to only those people also following an issue? (Don't know if this is technically feasible...)

dww’s picture

One of the goals of the Praire initiative is to make d.o a more effective place to collaborate. One of the strategies to achieve that goal is to help ensure that the right people are involved in issues at the right time. One of the tactics for that is to make it obvious who's already "involved" in an issue, and another is to make it easy to invite people who aren't yet involved but should be. An obvious example is an issue that touches the UI in some way -- we want to know that UX people are following. Obviously, once people actually comment their participation is more explicit, but even knowing that (e.g.) yoroy is already following something means I don't have to try to contact him out of band. There's obviously more to this, like making user profiles more helpful in understand what kind of knowledge/experience people have, but as a first step, even given the implicit reputation system in all of our heads, seeing a list of usernames (and ideally pictures) of who's following helps me decide if we have enough "firepower" in an issue to make decisions and progress or not.

Furthermore, the Internet is full of services that let you "follow" things/people and they're happy to disclose both your followers and who/what you're following.

Finally, anything being publicly discussed on d.o is public. ;) It's not like this is a naughty site full of sensitive private info and we don't want to let anyone know our viewing/reading habits. Any presumption of privacy here (in terms of totally open, public content) is misplaced, IMHO.

What do we gain by *not* providing this info? Some self-righteous sense that our privacy policy is "better" than e.g. Twitter? The use-cases for anonymous following suggested here seem like a stretch. Policy discussions are still public discussions. I don't see why you'd need or want to hide the fact that you're interested in a given policy discussion. If you *really* want it to be anonymous, bookmark the thread in your browser, don't follow it. ;)

I'm not going to put energy into implementing this while there's still a debate about it, but I think this can and should be public info, and that it could potentially aid in Getting Things Done(tm) on d.o by knowing who's already paying attention.

klonos’s picture

Fear enough Derek. I too see no use -personally- in hiding our contact info from issues we follow, but still you have to admit that it would at the very least be thoughtful and polite on our part to give other members of our community the option of anonymity without "banning" them from using the new follow system. How about meeting half way like this then?...

Add a "List me anonymously in the Followers list page" checkbox/option in each user's profile (I think that profile -> notifications would be a nice place). This way the Followers page could look like so:

People following this issue:

John Doe
Jane Smith
...
...
Me
You
Some Other Guy
+ 13 anonymous followers.

kyle_mathews’s picture

FileSize
46.26 KB

@klonos +1 to your compromise. Knowing that, say, webchick is following your issue is really valuable if you need/want her input on something.

Another thought to consider. Instead of placing the followers list on another page where it's relatively hard to find, why don't we borrow an idea from github. They place right below the initial question the avatars and names of everyone following the issue. Very neat. Very easy to scan. Placing this information on another page just hides it unnecessarily.

Github screenshot

dww’s picture

-1 to doing it on the same page. Too much visual clutter, especially since this list could grow to 100s of users.

I'm not sure how easy it would be to implement the compromise using views. I'm also not sure it's worth the effort. I need *compelling* arguments that it's a big problem to just make this always visible to think it's worth a bunch of extra labor. I'm reasonably sure you could click this together in views in about 15 minutes if we do it the simple/easy way.

dww’s picture

Oh, and furthermore, the point of the anonymous follow was meant to be for specific issues. I don't know that heyrocker (a D8 initiative leader) would want to hide himself on every issue. If anything, the compromise would need to be a 2nd flag in tiny grey print "Follow anonymously" (or something) and teach the various parts of tracker2 and project_issue that care that both flags should impact your tracker and email, but separate them for this page so we still get the 99% who are visible and the 1% who followed anonymously.

Again, *way* too much work IMHO. But, if we wanted a compromise, that seems better than a global "I'd like a tin-foil hat" killswitch. ;)

Cheers,
-Derek

Dane Powell’s picture

I'm just going to brainstorm for a second here- it seems that the primary use of this feature is to find out if a particular person that you are replying to is following an issue, so what if we added an input filter, similar to the issue number expander, that would find @user strings and then indicate next to them whether that user is following the issue or not? This could be in addition to or instead of a separate page.

kyle_mathews’s picture

My thought (though I didn't express it) was that the avatars and/or names of following users would only take a max of one line. If there was more followers than fit on one line, it'd truncate the list and say "and 27 more" If you click on "and x more", there'd be a little popup that would then grab the remaining users. This is the same pattern Facebook, Google Plus and a number of other social networking sites follow.

My worry is if you put the list of followers on another page, there'll be a huge drop-off in the # of people who see it. Something akin to project issue statistics page. It was years after I started using d.o. that I first noticed that page and I still can't consistently remember how to find it.

This is pretty valuable information and I think it should be front and center on the page.

klonos’s picture

@dww, #21:

a global "I'd like a tin-foil hat" killswitch

LOL :D

If anything, the compromise would need to be a 2nd flag in tiny grey print "Follow anonymously" (or something)...

Nice thinking Derek! I was about to propose some kind of "Anonymize me" link/hover-over button in the follower list (only for own name), but that would make "anonymizing" ones listing an 2/3 step thing. This could be a "follow anonymously" checkbox right under the follow button.

BTW, ...could someone please let me know how is the "following" flag currently stored in the db? Is it a separate table/field/what? Thanx in advance.

gdd’s picture

@dww I don't see any value in having my name public in a follow list, and I see value in having it sometimes hidden, so I am perfectly happy with the global killswitch compromise.

catch’s picture

I'm not sure we need names of followers, I'm less worried about people knowing which issues I'm following than pinging me about issues which I'm not...

But in another issue someone mentioned doing a graph of when people followed (maybe by month or something), that does seem like useful information (or at worst, it'd look cool), in that if 100 people follow an issue the say it's posted then ignore it for 2 years it's different to something that was in the queue for 6 months and suddenly became a hot issue (i.e. a bug exposed by a contrib module or similar).

dasjo’s picture

But in another issue someone mentioned doing a graph of when people followed (maybe by month or something), that does seem like useful information (or at worst, it'd look cool), in that if 100 people follow an issue the say it's posted then ignore it for 2 years it's different to something that was in the queue for 6 months and suddenly became a hot issue (i.e. a bug exposed by a contrib module or similar).

that's in #1307540: Provide charts that visualize issue activity over time

Michelle’s picture

Put me down as another not keen on being listed. I'm not so set on it that I will fight to stop it from happening but I wanted to at least add my voice to the "don't list me" side of things. One of my favorite things about the new follow system was to be able to follow anything without having to post something sensible to justify my being there (I loathe "subscribe" posts and would just not follow an issue rather than do it if I had nothing useful to say). I also like that I can track things that I think are questionable behavior that I'm not sure, yet, if it should have maintainer involvement. So I have various reasons for using "follow" and the only time I would be comfortable being listed is if I am actually participating and, in that case, I'm already listed as a post author so a secondary list would be pointless.

Michelle

klonos’s picture

...people will still have the option to opt-out from being listed. See #21

Michelle’s picture

#21 was a suggestion that he also listed as being way too much work. This issue is still active, not RTBC, which, generally speaking, means thoughts are still welcome, so I shared mine. I also acknowledge I'm not the one who would be doing the work so this isn't something I'm going to fight if most people are ok with it. But there's no way of knowing if most people are ok with it if those that aren't don't speak up.

Michelle

klonos’s picture

Can you pretty please leave our debate on other issues aside and cool down? I merely pointed to #21 to let you know that people expressed that concern before and that whoever decides to work on this will most likely make an effort to take care of it some way.

Michelle’s picture

I haven't mentioned any other issues. I'm responding to your comment in this issue, #29, where you say "people will still have the option to opt-out from being listed" which implies it's a done deal and therefore no need for me to add my thoughts, which is incorrect.

Michelle

stewart.adam’s picture

It would be great to have this feature at a user level as well as an issue level, i.e. I could take a look at a list of all my or another user's followed issues.

dww’s picture

stewart.adam’s picture

Those pages only display issues which the user has commented, not followed... This would be perfect, but would only work if I still typed "subscribe..." in each thread I wanted to keep tabs on.

dww’s picture

Wrong. It's all issues you follow, regardless of if you commented or not.

dww’s picture

For example, I just started following #1963476: datetime.module - Convert theme_ functions to Twig which is now near the top of https://drupal.org/project/issues/user/dww even though I didn't comment there.

Cheers,
-Derek

p.s. Sorry for "Wrong." -- it's been a weird morning here and I didn't get enough sleep. ;)

stewart.adam’s picture

No offense taken, I was indeed wrong ;)

I think the 'last updated' field threw me off; lately I've been following a few bugs that were older and confused when I didn't see them appear in the list (which was only populated by posts I had commented in). That makes perfect sense, as the ones I commented in are the most recently updated ones. My apologies!

dww’s picture

Yup, that's the confusing part. It's sorted by when the issue was last updated, and (thank god) the act of you following it doesn't update it.

Glad you took no offense. :)

Cheers,
-Derek

klonos’s picture

The missing part is not the functionality, but the fact that there is no UI to get to this information. A "Issues" tab in each user profile page (in addition to the "Profile", "Posts" and "Commits" tabs) would be great.

dww’s picture

"Posts" also shows issues you're following.

Anyway, we're totally off topic here. To add such a tab (not sure it's a good idea) would have to be a feature request in the Drupal.org Customizations queue.

mgifford’s picture

Issue summary: View changes
Issue tags: +maintain

I like this idea.

Builds a bit of a sense of the individuals who are about a particular issue.

mgifford’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev
mgifford’s picture

There is more back-end discussion about what this could look like here:
https://disambiguity.notableapp.com/posts/960b8ce5781fb3cca2aadcec808f68...

I brought the ideas over into #2212591: Following up on Prairie Initiative Project Page

YesCT’s picture

related dreditor github issue
https://github.com/dreditor/dreditor/issues/116 "add a participant list button like create commit message button"

Steven Jones’s picture

So we don't have privacy of which issues we are following anyway, because there's a nice search field here:

https://drupal.org/project/issues/search?project_issue_followers=Steven+...

Which shows all the issues a particular user is following.

Is there a global opt-out of that? Can't see one.

So...we should either enforce some kind of privacy of issues I'm following, or be done with it, and add a list of users to the issue page somewhere.