Simple thing:
The comments above the views_join class make it seem as though "extra type" is another parameter to the construct function when in fact it is nested within the extra array. A simple patch follows to make this more clear.

CommentFileSizeAuthor
#1 class_definition_comments_misplace_variable_hierarchy-1298418-1.patch649 byteslliss
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lliss’s picture

lliss CreditAttribution: lliss commented
FileSize
class_definition_comments_misplace_variable_hierarchy-1298418-1.patch649 bytes
bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Reviewed & tested by the community

Thank you.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

Thanks for providing the patch! Small contributions like this adds up to big changes. Please continue to contribute.

Commited to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.