Warning: require_once(/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.basic.inc) [function.require-once]: failed to open stream: No such file or directory _registry_check_code() függvényben (/usr/home/pannon/www/includes/bootstrap.inc 2935 sor).
Warning: require_once(/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.basic.inc) [function.require-once]: failed to open stream: No such file or directory _registry_check_code() függvényben (/usr/home/pannon/www/includes/bootstrap.inc 2935 sor).
Warning: Missing argument 1 for NewsletterMail::__construct(), called in /usr/home/pannon/www/sites/all/modules/mailsystem/mailsystem.module on line 293 and defined NewsletterMail->__construct() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 27 sor).
Notice: Undefined variable: lid NewsletterMail->__construct() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 35 sor).
Notice: Trying to get property of non-object NewsletterMail->getSubscribers() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 60 sor).
Notice: Trying to get property of non-object NewsletterMail->getSubscribers() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 70 sor).
Notice: Trying to get property of non-object NewsletterMail->__construct() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 40 sor).
Notice: Trying to get property of non-object NewsletterMail->__construct() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 41 sor).
Notice: Trying to get property of non-object NewsletterMail->getNodes() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 154 sor).
Notice: Trying to get property of non-object NewsletterMail->getNodes() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 159 sor).
Notice: Trying to get property of non-object NewsletterMail->getQuery() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 130 sor).
Notice: Trying to get property of non-object NewsletterMail->__construct() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 48 sor).
Notice: Trying to get property of non-object NewsletterMail->getNewsletterData() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 88 sor).
Notice: Trying to get property of non-object NewsletterMail->getNewsletterData() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 93 sor).
Notice: Trying to get property of non-object NewsletterMail->getNewsletterData() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 97 sor).
Notice: Trying to get property of non-object NewsletterMail->getNewsletterData() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 100 sor).
Notice: Trying to get property of non-object NewsletterMail->getNewsletterData() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 102 sor).
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'title' cannot be null: INSERT INTO {newsletter_newsletters} (title, send_id, template_id) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => [:db_insert_placeholder_1] => 1 [:db_insert_placeholder_2] => ) NewsletterMail->getNewsletterData() függvényben (/usr/home/pannon/www/sites/all/modules/newsletter/includes/newsletter.mail.inc 104 sor).

Comments

ParisLiakos’s picture

Some more info please?
how did you get this message?what where u doing before?

Guzmosz’s picture

Just installed this module, and I just got this message

ParisLiakos’s picture

Can you verify that this file: includes/newsletter.basic.inc exists and it has correct permissions?
seems drupal cant read it

itserich’s picture

Do you have Simplenews installed? I got error messages when I had both Simplenews and Newsletter installed and I think disabling Mail System module fixed it. I think I had to delete a module from the modules folder because the site was inaccessible including the list of modules.

ParisLiakos’s picture

Project:Newsletter» Mail System
Version:7.x-1.0-alpha8» 7.x-2.x-dev

I checked it a bit and seems mailsystem module creates a class (NewsletterMail) that its name conflicts with a newsletter class that already exists.
thanks itserich for the hint:)

Guzmosz’s picture

Project:Mail System» Newsletter
Version:7.x-2.x-dev» 7.x-1.0-alpha8

Yes I have a simplenews module, but i disabled that before I installed the newsletter modul.
I will try to remove simplenews

Sorry, my english is bad :(

ParisLiakos’s picture

Title:Error - site down» Conflict with Newsletter Module
Project:Newsletter» Mail System
Version:7.x-1.0-alpha8» 7.x-2.x-dev

You have to disable mailsystem too

Guzmosz’s picture

And this file is missing

includes/newsletter.basic.inc

maybe the installation not completed

ParisLiakos’s picture

Guzmosz: search for this file in your sites/all/modules/newsletter directory
So all together sites/all/modules/newsletter/includes/newsletter.basic.inc

Guzmosz’s picture

Ah
It's there i fond it

pillarsdotnet’s picture

Project:Mail System» Newsletter
Version:7.x-2.x-dev» 7.x-1.x-dev
Status:Active» Closed (cannot reproduce)

I can assure you that Mail System does not create a class called NewsletterMail.

ParisLiakos’s picture

Indeed.my check was very fast:)
It does not create a class but rather an instance of it.
It doesn't provide the $lid argument.thats what all these warnings are about that finally end up to the PDOexception.

pillarsdotnet’s picture

What is a '$lid' argument?

If NewsletterMail implements MailSystemInterface then it should not need a '$lid' argument.

If it does not implement MailSystemInterface, then it shouldn't be registering itself with Mail System. (Conversely, Mail System shouldn't be trying to create an instance of it.)

The heuristics that Mail System uses to guess which classes might possibly implement MailSystemInterface are a bit on the fuzzy side, and I may have to develop a blacklist with NewsletterMail as the first entry, especially if NewsletterMail lacks a constructor with zero arguments.

ParisLiakos’s picture

No it doesn't implement it.it just happens to be in a file named newsletter.mail.inc ?
i am not sure yet,how your module instantiates it.

ParisLiakos’s picture

class NewsletterMailSystem implements MailSystemInterface { ... }

Thats the class that implements MailSystemInsterface.
Should i must change my class names then?

eg have
class NewsletterMail implements MailSystemInterface { ... }

and figure out an other name for the current NewsletterMail class?Would this make my module work fine with yours?

And that how i register it:

  $mail_modes = variable_get('mail_system', array('default-system' => 'DefaultMailSystem'));
  $mail_modes['newsletter'] = 'NewsletterMailSystem';
  variable_set('mail_system', $mail_modes);

I have the correct name there,so maybe the problem is that it sits in file called newsletter.mail.inc?
i saw some comments in your module about making assumptions that the class should exist in xxx.mail.inc

pillarsdotnet’s picture

Title:Conflict with Newsletter Module» Mail System needs a better way of determining which classes implement MailSystemInterface
Project:Newsletter» Mail System
Status:Closed (cannot reproduce)» Active

Okay; I know what I need to do.

TahitiPetey’s picture

So, is this problem fixed? I just tried to install Mail System module (I already had Newsletter installed and enabled) and it crashed with this error:
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'title' cannot be null.

pillarsdotnet’s picture

Mail System doesn't create any databases.

ParisLiakos’s picture

@#17 those modules are still incompatible.
When this issue is marked as fixed it will be ready,please be patient:)

itserich’s picture

The Mail System conflict with Newsletter appears to be fixed.

I have both enabled and am not getting error messages...

ParisLiakos’s picture

Yes, Newsletter (dev version) and Mailsystem are now compatible, but this issue still needs fixing i guess:)

pillarsdotnet’s picture

Possible solution Drawback
(Status quo) Attempt to load each registered class and test which ones implement MailSystemInterface. Some classes will produce runtime errors.
Require that classes implementing MailSystemInterface be specially registered somehow. Requires implicit cooperation from every mail-sending module author.
Build a static list of classes which are known to implement MailSystemInterface. Requires a new MailSystem release whenever a new class implementation is found and/or announced.

@todo

File a feature request against D8/D9 core asking that the class registry be extended to track the interface and/or parent classes implemented by each loadable class file.

znerol’s picture

May I suggest the following battleplan to resolve this issue:

  1. Introduce
    hook_mailsystem_info

    : A module implementing

    MailSystemInterface

    should declare it in this hook (classname along with a human readable description), also expose

    hook_mailsystem_info_alter
  2. Implement
    hook_mailsystem_info

    for core mailsystems (default / testing).

  3. Move the auto-discovery code to a another module which implements hook_mailsystem_info_alter where it tries to fill the gaps. Users having trouble with the auto discovery can switch it off and pester authors of other modules to implement
    hook_mailsystem_info

    .

cfischer50’s picture

I just got the PDO exception described in the issue summary when enabling mimemail and mailsystem. Based on this discussion:
I disabled mimemail and mailsystem, disabled simplenews, enabled mimemail and mailsystem, and then re-enabled simplenews. No errors. Thanks to all for posting!