Attached

Files: 
CommentFileSizeAuthor
#4 code_style_field_ui.test-1.patch1.13 KBChi
PASSED: [[SimpleTest]]: [MySQL] 33,133 pass(es). View
#1 code_style_field_ui.test-0.patch1.13 KBChi
PASSED: [[SimpleTest]]: [MySQL] 33,149 pass(es). View

Comments

Chi’s picture

Status: Active » Needs review
FileSize
1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 33,149 pass(es). View
larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Straight forward

catch’s picture

Status: Reviewed & tested by the community » Needs work

While we're there could we remove this double space before the strtolower? Same thing appears each time.

+    $type_name =  strtolower($this->randomName(8)) . '_test';
Chi’s picture

Status: Needs work » Needs review
FileSize
1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 33,133 pass(es). View
TR’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me for both D8 and D7.

catch’s picture

Version: 8.x-dev » 7.x-dev

Thanks! Committed and pushed. Moving to 7.x for webchick.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.