Draggable Views throws several notices if the view is showing a fixed number of items (i.e. no real pager).

CommentFileSizeAuthor
#4 fixed_number_per_page-1292536-4.patch4.61 KBdalin
#3 fixed_number_per_page-1292536-3.patch3.15 KBdalin
#1 fixed_number_per_page-1292536-1.patch910 bytesdalin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Status: Active » Needs review
FileSize
fixed_number_per_page-1292536-1.patch910 bytes
dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Status: Needs review » Needs work

Actually I found this today:
$view->use_pager()
http://drupalcode.org/project/views.git/blob/481cec026c826b19b45e3555fe8...

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Status: Needs work » Needs review
FileSize
fixed_number_per_page-1292536-3.patch3.15 KB

Here's a new one that fixes a few more places and uses $view->use_pager().

But everything that touches pagers probably needs to be rewritten to use Views' new pager system anyway.

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
FileSize
fixed_number_per_page-1292536-4.patch4.61 KB

Here's another one that gets around the fact that all of the futzing with the pager globals is currently broken (due to Views having a new paradigm for pagers now).

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Notice: Undefined index: id in draggableviews_views_pre_execute(), line 252/258, draggableviews.module » Notice: Undefined index: id in draggableviews_views_pre_execute(), line 252, draggableviews.module

...coming from #1198810: not working with attachment display. The errors are:

Notice: Undefined index: id in draggableviews_views_pre_execute() (line 252 of /sites/all/modules/draggableviews/draggableviews.module)
Notice: Undefined index: id in draggableviews_views_pre_execute() (line 258 of /sites/all/modules/draggableviews/draggableviews.module)

I confirm that the patch in #4 above fixes the error.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Notice: Undefined index: id » Notice: Undefined index: id in draggableviews_views_pre_execute(), line 252/258, draggableviews.module

...line 258 too.

medden’s picture

medden CreditAttribution: medden commented
Title: Notice: Undefined index: id in draggableviews_views_pre_execute(), line 252, draggableviews.module » Notice: Undefined index: id in draggableviews_views_pre_execute(), line 252/258, draggableviews.module

I can confirm this patch (#4) worked for me and resolved the errors I was getting.

rkeppner’s picture

rkeppner CreditAttribution: rkeppner commented
Status: Needs review » Reviewed & tested by the community

I can also confirm that patch (#4) worked to correct the error messages I was seeing.

mesr01’s picture

mesr01 CreditAttribution: mesr01 commented

Thanks dalin!

ygerasimov’s picture

ygerasimov CreditAttribution: ygerasimov commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you @dalin!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.