RTL support [#1290386]

Thanks for your efforts in making this theme

here's a patch for rtl support:

added /* LTR */ in original css files
added rtl css files
added rtl images (attached below)
modified "theme-settings.php" to generate the rquired rtl css file on settings submit

(admin theme not modified added only /* LTR */ to it)
(subtheme not modified)

here's the workflow for maintaining rtl css http://drupal.org/node/798192#comment-2993500

Regards

Comment	File	Size	Author
#7	adaptivetheme-rtl-1290386-7.patch	29.96 KB	laken
	adaptivetheme_rtl_images.tar_.gz	2.24 KB	ahwebd
	at_rtl.patch	33.23 KB	ahwebd

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Jeff Burnz CreditAttribution: Jeff Burnz commented 25 September 2011 at 20:55

If I could get global $language into the submit handler I can flip the layout also, but I couldn't make it work, I don't know why I keep getting these windows line ending because I have it set to unix line endings... anyway my two years of windows is coming to an end, yay, back to the mac!

I'll spend some time on this early in the week, because I have a few other things to clean up and this could go in sooner rather than later.

Thank-you very much, awesome work!

Comment #2

ahwebd CreditAttribution: ahwebd commented 27 September 2011 at 05:45

Comment #3

Jeff Burnz CreditAttribution: Jeff Burnz commented 5 October 2011 at 12:27

Version:

7.x-2.0

» 7.x-2.x-dev

I am sorry this did not make it into the 7.x-2.1 release, I simply ran out of time for testing, however this is very high on the agenda for getting into the next release. I am planning on reasonably regular maintenance releases so there will be plenty of opportunity to get this in.

Comment #4

ahwebd CreditAttribution: ahwebd commented 5 October 2011 at 14:57

ok :)

Comment #5

amirtaiar CreditAttribution: amirtaiar commented 19 October 2011 at 11:31

Thank you!!!
There is a missing part for me here -
If I create a subtheme located in sites/all/themes.
And this sub theme created from the adaptivetheme_subtheme which dont have this files - at.layout-rtl.css, like the adaptivetheme_admin one, which should I use?
It's a bit confusing...

Comment #6

Jeff Burnz CreditAttribution: Jeff Burnz commented 7 May 2012 at 10:40

Component:	Code	» CSS/HTML
Status:	Needs review	» Closed (won't fix)

For now I will like to close this as wont fix, I am very sorry but I do not have time to port this forward to 7.x-3.x nor time to review for 2.x.

What I would say if that someone wants to come on board as a co-maintainer and "own" the RTL features and keep them up to date, please tell me, I am very open to this idea.

Due to various circumstances I need to make some hard calls about what I can and cannot afford to support (in terms of time and financial commitment to open source), sadly this means some things won't be supported by default.