it'd be nice for at least the month block view, if not week/month/year page views, to lightly grey-out days in the past (conceptually like disabling form elements). seems like we'd just need to put another class into the td called "past", in addition to the one we do for "today". then, we could do whatever we wanted in the .css.

maybe this is a small enough change i can actually roll my own patch for it... we'll see if someone else gets to it first. ;)

Comments

KarenS’s picture

Could be a nice idea. I've not seen it done on other calendar applications. If someone provides a patch, I'd be glad to look at it.

dww’s picture

Status: Active » Postponed
JohnG-1’s picture

+1 : idea of greyed-out 'past' days juxtaposing colourful-lively 'active' days; ... and dump the alarming-pink 'today' method ? (please)

Also - at the risk of being off topic / broadening an interesting discussion - I'd like to simplify the colour-coding. IMO it's currently too bitty:

1. use colour-coded block backgrounds instead of stripes,
2. keep colour-code consistent for a given content-type / taxonomy term / etc (admin settings? or key off a Calendar View Filter somehow ?),
3. apply colour-codes consistently to Year, Month, Week and Day Views. (I don't know how to present 2 colours for one day in year view ... split into stripes ? ;)
4. and I'll have a large Coke with that, please ;)

KarenS’s picture

Title: grey-out days in the past » Theme changes
Status: Postponed » Active

FWIW, the calendar module css is all white, black, and grey, except for a light yellow background for days with events in the mini calendar and the 'today' color (which I agree is not the greatest color, it's inherited from the event module and never changed). All other colors you see, like the striped colors for odd and even rows in the tables, are added by core or your theme, not put there by the calendar module. I tried to find a way to get rid of the odd/even colors, but the odd and even classes are added by core and then modified by the core themes when you use theme_table(), and I couldn't find any easy way to override them in the calendar module. That may require creating a custom version of theme_table() that does not add odd/even classes.

So I would be open to patches for:

1) An alternative color for 'today' -- something neutral that will work with a black/white/grey/light yellow combo and look good in most themes.

2) A custom theme_table function that doesn't use odd and even classes.

3) Changes to grey out days in the past (need another grey color for this that works well with the current combo).

JohnG-1’s picture

by stripes I don't mean the zebra thing, I mean the colour-bar (div class="calendar monthview" ... div class="stripe-1"... span class="stripe") across the top of each 'event block' (then thing that's enclosed by the div class="calendar monthview") that corresponds to the colour-code in the legend block ... I'm suggesting getting rid of these little stripes, and just colour-coding the background of the whole 'event block' .

KarenS’s picture

Title: Theme changes » Theme changes - gray out days in past

Customizing the stripes is already created as another issue, so you can add your suggestions to that.

I'm leaving this issue open for the original request.

KarenS’s picture

Status: Active » Fixed

I added a class for 'past' and 'future' and also changed the default color for 'today' to grey. There is nothing applied as a color for past or future, but they are there if you want them :)

dww’s picture

Slick, thanks Karen. ;)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.