Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Splitting this off as a drupalorg-specific task as part of the overall plan at #34496: [meta] Add Flag module to allow users to subscribe/unsubscribe without posting a comment.
#397458: Revamp mailing logic to leverage flag module is now basically done. However, a few of the possible settings don't make any sense on drupal.org. In particular, no one in their right mind should ever select "All issues" as the choice for the default global setting for email notifications (which will be used for any projects that don't define explicit notification settings).
So, at the very least, this issue is about adding a form_alter to drupalorg_project to remove that particular option from the form that will live at user/N/project-issue.
It's possible we'll uncover other UI/UX tweaks we want to do which should live in module code, not in bluecheese, so we might add more stuff here as we work through #1284694: Tweak UI of issue following (bluecheese). Stay tuned about that...
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | drupalorg.project-default-deny-all.6.patch | 753 bytes | sun |
| #2 | 1284716-2.drupalorg-issue-notification-ui-tweak.patch | 1.07 KB | dww |
| #1 | 1284716-1.drupalorg-issue-notification-ui-tweak.patch | 870 bytes | dww |
Comments
Comment #1
dwwAFAIK, this is the only module-related tweak we need. Hiding the 'All issues' option for the 'default' row at user/N/project-issue. Everything else (so far) is happening in bluecheese over at #1284694: Tweak UI of issue following (bluecheese).
Comment #2
dwwsun wanted a code comment for this alter...
Comment #3
dwwAlso, since #1284694: Tweak UI of issue following (bluecheese) is just CSS and there's nothing else we need to do for that, re-titling to be more specific about what's happening here.
Comment #4
sunCoolio, thanks! :)
Comment #5
dwwCommitted, pushed, merged into bzr and deployed. There's no harm having this live now, it's just trying to alter a form_id that doesn't exist yet. And it's one less thing to worry about when the rest of #34496: [meta] Add Flag module to allow users to subscribe/unsubscribe without posting a comment goes live.
Comment #6
sunNeeds to be updated for latest changes.
Tested manually.
Comment #7
dwwThanks, good catch! Reviewed, tested, committed, and pushed.