Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After migration none of my fields are set to required any longer. This patch fixes it, but I think there might be more to this bug- I'm not sure about _content_migrate_get_instance_values - it looks the problem may be just above my patch:
// Pass field settings to the instance, in case they are needed.
$field_value = array(
'require' => $instance_value['required'],
'type' => $instance_value['type'],
'module' => $instance_value['module'],
'settings' => unserialize($instance_value['global_settings']),
);
i.e., if we're passing field settings to the instance, shouldn't it be $instance_value = array( ... ? $field_value variable seems to be quickly forgotten after this.
Comment | File | Size | Author |
---|---|---|---|
#2 | cck-7.x-dev-required.patch | 868 bytes | attheshow |
cck-required.patch | 1.07 KB | Jody Lynn |
Comments
Comment #1
attheshow CreditAttribution: attheshow commentedThis patch appears to work for me. Thanks!
Comment #2
attheshow CreditAttribution: attheshow commentedThis patch wasn't applying cleanly for me using Drush Make, so I've tried re-creating it.
Comment #3
drzraf CreditAttribution: drzraf commentedconsistently reproducible
patch appears to work
should we increase priority to major ?
Comment #4
drzraf CreditAttribution: drzraf commentedshould I take the responsibility to mark this RTBC ?
Comment #5
jcisio CreditAttribution: jcisio commentedIt works. And I don't see any side effect.
Comment #6
colanThanks! Committed in be10579.