After migration none of my fields are set to required any longer. This patch fixes it, but I think there might be more to this bug- I'm not sure about _content_migrate_get_instance_values - it looks the problem may be just above my patch:

// Pass field settings to the instance, in case they are needed.
      $field_value = array(
        'require' => $instance_value['required'],
        'type' => $instance_value['type'],
        'module' => $instance_value['module'],
        'settings' => unserialize($instance_value['global_settings']),
      );

i.e., if we're passing field settings to the instance, shouldn't it be $instance_value = array( ... ? $field_value variable seems to be quickly forgotten after this.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

attheshow’s picture

This patch appears to work for me. Thanks!

attheshow’s picture

FileSize
868 bytes

This patch wasn't applying cleanly for me using Drush Make, so I've tried re-creating it.

drzraf’s picture

consistently reproducible
patch appears to work
should we increase priority to major ?

drzraf’s picture

Priority: Normal » Major

should I take the responsibility to mark this RTBC ?

jcisio’s picture

Status: Needs review » Reviewed & tested by the community

It works. And I don't see any side effect.

colan’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thanks! Committed in be10579.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.