Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Maybe it's just me, but this link caption threw me off a bit when I first saw it.
From reading it, I assumed that clicking it would actually activate the module I had just installed. But all it does is take you back to the module overview.
If that's its function, then it should probably just be called "Back to modules list" or something similar.
Steps to reproduce
- Go to the "Add new module" (admin/modules/install) page.
- Add a module through any of the options on the page and click on the "Continue" button.
- It will go to another page, where we can see the link.
Proposed resolution
- No change.
- "Back to modules list" In #48 it is explained why this isn't quite right.
- Install newly added module on the extend page
- allow users to enable it directly from that screen instead
- add your suggestion ..
Remaining tasks
Discuss options
User interface changes
Before
After
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #47 | afterPatch#44.png | 17.79 KB | Asha Nair |
| #47 | beforePatch#44.png | 21.27 KB | Asha Nair |
| #44 | after-patch.jpg | 1.03 MB | ranjith_kumar_k_u |
| #44 | before-patch.jpg | 1.06 MB | ranjith_kumar_k_u |
| #44 | 1273676-44.patch | 1.47 KB | ranjith_kumar_k_u |
| |||
Comments
Comment #1
dawehnerAs drupal core has a string freeze this is probably to late to change, but i agree this is really confusing.
Comment #2
ralf.strobel CreditAttribution: ralf.strobel commentedSo should we make it 8.x-dev then?
Comment #3
dawehnerYes, this makes sense.
Comment #4
ralf.strobel CreditAttribution: ralf.strobel commentedBy the way, as an alternative to changing the text, I would actually like it if the link really did activate the module I just installed.
Comment #5
rpayanmChanged from "Enable newly added modules" to "Back to modules list".
Comment #6
rpayanmComment #7
webchickYeah, I could see this. However, I believe that text was chosen as a reason, to spur an 'action' so it'd be good for the UX team to sign-off on this.
Comment #8
webchickOops.
Comment #9
Bojhan CreditAttribution: Bojhan commentedCant we set them to the actual module # on the module page? I think that having an action here makes a lot more sense.
Comment #10
jochem_nl CreditAttribution: jochem_nl commentedI think both arguments are good.
It should be clear to the user to click the link so he/she can enable the modules.
But it also should include something about the page where you end up after clicking the link.
My suggestion is "Back to modules list to enable newly added modules"
It maybe to long.
Comment #11
jochem_nl CreditAttribution: jochem_nl commentedComment #12
Bojhan CreditAttribution: Bojhan commentedWhy not just "back to the list"
Comment #13
fragtom CreditAttribution: fragtom commentedI have installed Update Manager to see functionality. Would also prefer to shorten the link-text. "Back to modules list"
Comment #14
snte CreditAttribution: snte commentedgoing to review it
Comment #15
jochem_nl CreditAttribution: jochem_nl commentedOkay, I agree. I'll make a patch with "Back to modules list"
Comment #18
snte CreditAttribution: snte commentedCan't review #15 because i cannot install a module via Extend, tested locally (DevDesktop) and on simplytest.me, with random modules (ctools, admin_menu, google_analytics). Issue here: https://www.drupal.org/node/2042447
Comment #19
jhedstromProbably needs to be bounced to 8.1 since beta is supposed to freeze strings.
Comment #20
Bojhan CreditAttribution: Bojhan commentedNope, no freezed strings.
Comment #21
ChuChuNaKu CreditAttribution: ChuChuNaKu commentedComment #22
ChuChuNaKu CreditAttribution: ChuChuNaKu commentedI tested comment number 15 and the patch ran cleanly. However, as comment number 18 stated , I was unable to add a module. I tried installing the date module using drush, but it doesn't display on the Extend page even after clearing the cache.
#SprintWeekend2015
Comment #23
ChuChuNaKu CreditAttribution: ChuChuNaKu commentedComment #24
mikemiles86Comment #26
Kumar Kundan CreditAttribution: Kumar Kundan commentedI have installed path auto module to see functionality. Would also prefer to shorten the link-text. "Back to modules list".
Same Issue with drupal 7 also.
Comment #28
wturrell CreditAttribution: wturrell as a volunteer commentedHere's a new patch for 8.2.x
Comment #30
wturrell CreditAttribution: wturrell as a volunteer commentedThis is failing because there's a test for the old link text in UpdateUploadTest.php:
$this->assertLink(t('Enable newly added modules'));I've not changed a test before - do I literally just add that to the patch as well?
(Also, are we still at the stage in the release cycle where this should be against 8.2.x rather than 8.3.x, as it's non-disruptive?)
Comment #31
Thew CreditAttribution: Thew at Google Code-In commentedUpdate the test. This should pass now.
Comment #32
Thew CreditAttribution: Thew at Google Code-In commentedComment #43
smustgrave CreditAttribution: smustgrave at Mobomo commentedThis issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.
So reading the comments and this seems to be very close.
Patch #31 needs to made for 10.1.x and the issue summary needs updating about what is being fixed actually, to match the patch
Please do not simply just reroll.
Comment #44
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #45
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #46
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #47
Asha Nair CreditAttribution: Asha Nair at Zyxware Technologies commentedApplied patch #44 successfully in 10.x. It changes the text to 'Back to modules list'
Comment #48
smustgrave CreditAttribution: smustgrave at Mobomo commentedBrought this up in the #ux channel
from @rkoller
So think the wording needs some more thought. Leaving Needs issue summary update tag for that new proposal.
Comment #50
quietone CreditAttribution: quietone at PreviousNext commented@ranjith_kumar_k_u, When working on issues it is always helpful to read previous comments and to comment on what you have done and why. Your patch is not accompanied by any explanation or your thoughts on this proposed change. I also see that the comment prior to your reroll has in bold "Please do not simply just reroll." As far as I can tell by the patch and the (very large) screenshots that is what has happened. Therefor, credit has been removed per How is credit granted for Drupal core issues.
@Asha Nair, a second set of screenshots is not at all helpful.
I have updated the Issue Summary. I am setting this to Active because it needs discussion to decide on any text change before a patch is worked on.
Comment #51
quietone CreditAttribution: quietone at PreviousNext commentedI have closed #992190: Link to enable a new module after adding it via the Update Manager is confusing - allow users to enable it directly from that screen instead and added the proposal there to the issue summary. That was to add the module directly from the update page.