The shutdown function should be registered in hook_boot(), not hook_init(). In hook_init() it does not get added on cached pages. This is bad.

Files: 
CommentFileSizeAuthor
#1 hook_boot.patch739 bytesxjm
PASSED: [[SimpleTest]]: [MySQL] 1,865 pass(es).
[ View ]

Comments

xjm’s picture

Status:Active» Needs review
StatusFileSize
new739 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,865 pass(es).
[ View ]
xjm’s picture

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

Priority:Critical» Normal
Status:Closed (fixed)» Needs review
xjm’s picture

Title:Move registration of shutdown function from hook_init() into hook_boot()» [Rollback] Move registration of shutdown function from hook_init() into hook_boot()
xjm’s picture

Status:Needs review» Fixed
xjm’s picture

Okay, wow, that commit stuck the hunk in the wrong place and is essentially totally bogus. Thank you, test suite.

Fixed here:
http://drupal.org/commitlog/commit/364/5a17b5e4ed655c249ef4691e18a6e78a9...

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.