File Entity breaks the array output of the file field default formatter [#1270036]

When the "Generic file" display is used, viewing a File Entity results in a blank icon without a filename and the following error message are displayed:

Notice: Trying to get property of non-object in theme_file_link() (line 701 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in theme_file_icon() (line 739 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in file_icon_path() (line 781 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in file_icon_map() (line 823 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in file_icon_path() (line 796 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in file_icon_path() (line 796 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in file_icon_path() (line 796 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in file_icon_path() (line 796 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in theme_file_link() (line 708 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in theme_file_link() (line 708 of /[...]/modules/file/file.module).
Notice: Trying to get property of non-object in theme_file_link() (line 714 of /[...]/modules/file/file.module).

The root of the issue is in file_build_content, right after calling file_view_file(), it unset the #file property of its result. But the default file field formatter returns a render array using the file_link theme hook. This theme hook requires a file</file> variable, which in a render array translates to the the <code>#file property. So when the actual rendering of the array happens, theme('file_link') is called without the required file variable, resulting in the reported error messages.

Comment	File	Size	Author
#8	file_entity-n1270036-8.patch	776 bytes	DamienMcKenna
#8
#7	file_entity_check_theme_index_set.patch	761 bytes	yareckon
#7
#1	file_build_content_breaks_file_field_defaut_formatter-1270036-1.patch	1.01 KB	pbuyle
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pbuyle CreditAttribution: pbuyle commented 5 September 2011 at 14:26

File	Size
file_build_content_breaks_file_field_defaut_formatter-1270036-1.patch	1.01 KB

Here is a simple patch that avoid unsetting $file->content['file']['#file'] if it uses the file_link theme hook.

Comment #2

rickvug CreditAttribution: rickvug commented 6 September 2011 at 11:31

Status:

Active

» Reviewed & tested by the community

I can reproduce this problem by visiting a URL such as media/2. Applying the patch fixes the problem. Based on the description of the problem the small code change makes sense so marking RTBC.

Comment #3

andypanix CreditAttribution: andypanix commented 11 September 2011 at 18:50

Same problem me too. I can confirm that applying the patch fixes it.

Comment #4

amateescu CreditAttribution: amateescu commented 27 September 2011 at 21:36

I've been hit by this while working on #1201936: Move the media field to a non-required submodule. Tested the patch and I second the RTBC status.

Comment #5

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 27 September 2011 at 22:25

Status:

Reviewed & tested by the community

» Fixed

I'm dubious about this, but I guess we need it. Committed to 7.x-1.x.

http://drupalcode.org/project/file_entity.git/commit/63cfb6c

Comment #6

shaman365 CreditAttribution: shaman365 commented 6 October 2011 at 22:21

Heads up,

I am actually receiving this error with this patch:

Notice: Undefined index: #theme in file_build_content() (line 198 ....sites/all/modules/file_entity/file_entity.file_api.inc)

However, when I roll back the patch, I don't see any errors. I'm using the "URL to file" display style and my media field is being displayed in a view.

Comment #7

yareckon CreditAttribution: yareckon commented 17 October 2011 at 22:57

Version:	7.x-1.x-dev	» 7.x-2.x-dev
Status:	Fixed	» Needs review

File	Size
file_entity_check_theme_index_set.patch	761 bytes

Yeah we need to check if that index is set before reading it. Attached patch does so.

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 October 2011 at 15:18

File	Size
file_entity-n1270036-8.patch	776 bytes

Slightly improved formatting of the if() statement.

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 27 October 2011 at 02:40

The patch from #7 fixed the problem for me, I just cleaned up the changed line a little bit with my patch in #8. Can I RTBC the patch or should someone else do it?