Use .js instead of html.js in CSS

@Jacine

Do you have any idea why html.js was used in the first place?
Other than modifying the following (8.x) does anything need to be done to theme functions / templates to put this in place?

modules/book/book.css:html.js #edit-book-pick-book {
modules/color/color-rtl.css:html.js #preview {
modules/color/color.css:html.js #preview {
modules/contextual/contextual.css:html.js div.contextual-links-wrapper {
modules/openid/openid-rtl.css:html.js #user-login-form li.openid-link,
modules/openid/openid-rtl.css:html.js #user-login li.openid-link {
modules/openid/openid.css:html.js #user-login-form div.form-item-openid-identifier,
modules/openid/openid.css:html.js #user-login div.form-item-openid-identifier {
modules/openid/openid.css:html.js #user-login-form li.openid-link,
modules/openid/openid.css:html.js #user-login li.openid-link {
modules/overlay/overlay-child.css:html.js {
modules/overlay/overlay-child.css:html.js body {
modules/system/system.base-rtl.css:html.js input.form-autocomplete {
modules/system/system.base-rtl.css:html.js input.throbbing {
modules/system/system.base.css:html.js input.form-autocomplete {
modules/system/system.base.css:html.js input.throbbing {
modules/system/system.base.css:html.js fieldset.collapsed {
modules/system/system.base.css:html.js fieldset.collapsed .fieldset-wrapper {
modules/system/system.base.css:html.js .js-hide {
modules/system/system.theme-rtl.css:html.js fieldset.collapsible .fieldset-legend {
modules/system/system.theme-rtl.css:html.js fieldset.collapsed .fieldset-legend {
modules/system/system.theme.css:html.js fieldset.collapsible .fieldset-legend {
modules/system/system.theme.css:html.js fieldset.collapsed .fieldset-legend {
themes/bartik/color/preview.css:html.js #preview {
themes/bartik/css/style-rtl.css:html.js input.form-autocomplete {
themes/bartik/css/style-rtl.css:html.js input.throbbing {
themes/bartik/css/style.css:html.js input.form-autocomplete {
themes/bartik/css/style.css:html.js input.throbbing {
themes/garland/fix-ie-rtl.css:html.js fieldset.collapsible {
themes/garland/fix-ie-rtl.css:html.js fieldset.collapsed {
themes/garland/fix-ie.css:html.js fieldset.collapsible {
themes/garland/fix-ie.css:html.js fieldset.collapsed {
themes/garland/style-rtl.css:html.js fieldset.collapsible .fieldset-legend {
themes/garland/style-rtl.css:html.js fieldset.collapsed .fieldset-legend {
themes/garland/style.css:html.js fieldset.collapsed {
themes/garland/style.css:html.js fieldset.collapsible .fieldset-legend {
themes/garland/style.css:html.js fieldset.collapsed .fieldset-legend {
themes/seven/style.css:html.js fieldset.collapsed {
themes/seven/style.css:html.js input.form-autocomplete {
themes/seven/style.css:html.js input.throbbing {

I don't see how html.js is overqualified. It makes clear what it is, and avoid possible confusion if/when the same class is used elsewhere then in html. If there is no more rationale then ".js is just as efficient, let's do the change for the sake of it", I would recommend against it.

I think this patch should be committed. I see 3 reasons:

• Overqualified css selector
• Save a few octets
• More flexibility (in fact html5 doesn't require a html tag)

I have to agree that the two last can be seen as really minor or not important at all. But if later we decide to put the "js" class on the body tag for any good reason there will be no change needed in the css.

Not sure what this has to do with html5.

More flexibility (in fact html5 doesn't require a html tag)

Yeah, right ;)

I still see no valid reason for this change. Changing anything just for the sake of changing it is just a bad idea.

@dave well now that were changing markup & css all around drupal to make it clean "HTML5" (the magick buzzword)
then it woudn't make sense not to clean up the frontend where we can now were at it?
if we dont look at the markup & classes as a whole then were doing it wrong

Actually its valid not having eather the html or body tag - cause the browser knows it should be there - its crap for accessability though ;)

But the point here is that what frontend developers really really want is as little pre loaded weight as possible. the drupal way used to be to have tons of helpers "because then the themers might can use it" well were actually asking for as little weight as possible to get the job done.

if we follow the idea of not having legacy code, then we should really start to ask why does this helper class need a html.js and not just the .js

+1 on Everett’s patch in #3. Can we RTBC this yet?

@mortendk What is crap for accessibility?

Its inherited, html.js at very top level, so html.js & .js almost same thing.

Needs a reroll.

@jacine:

... but @idflood is correct in saying that HTML and BODY tags are NOT required, but that's neither here nor there.

That's a common misconception. HTML and BODY are not required in the HTML source. But they *are* reconstructed by the browser when building the DOM.

#3: html.js_.patch queued for re-testing.

Just a note that doesn't add much to this discussion: modernizr also adds a 'js' tag to the html element, so if you are using that code you carry two 'js' tags on the html element with your drupal pages. I've never seen code based on modernizr that uses anything but a simple .js selector.

I'm actually re-opening this issue.

For a couple of very simple reasons having nothing to do with, html5, browser magic, or not needing .

The extra specificity is completely pointless!! Is just simply not needed to begin with especially when being used in the way it's currently being used.

That being said the above patch needs work.

#3: html.js_.patch queued for re-testing.

Oh, this needs a re-roll because of the core directories.

I think the main purpose of .js class is tell browsers: It is JS enabled..we do something differently" (GLOBALLY, not just for HTML tag). Removing HTML tag or whatever, some of Drupal features may broken. It's another issue.

If not, we should do something like this at beginning...

<html class="js">
<head class="no-js">
</head>
<body class="no-js">
</body>
</html>

The .js class is only use to style or do things differently with css, or to hide things. That's about all.

The .js class does belong in the html. This issue is not related to that.

This is strictly about removing the html.js declaration in the css to a more simpler and less specific .js.

- won't break anything.
- allows themer to stop using html.js when they really don't want to.

Looks good to me.

Committed to 8.x.