This could be usefull inmany usecase and better for SEO.

CommentFileSizeAuthor
#14 ctools-n1265272-14.interdiff.txt863 bytesDamienMcKenna
#14 ctools-n1265272-14.patch1.73 KBDamienMcKenna
#12 302-temporary-redirect-1265272-12.patch1.49 KBrivimey
#9 302-temporary-redirect-1265272-9.patch1.49 KBjohnnydarkko
#7 303-temporary-redirect-1265272-5.patch984 bytesdimduj
#3 302-temporary-redirect-1265272-3.patch984 bytesdimduj
#1 ctools-page_manager_task_handlers_302redirect-1265272.patch3.58 KBdimduj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dimduj’s picture

dimduj CreditAttribution: dimduj commented
Status: Active » Needs review
FileSize
ctools-page_manager_task_handlers_302redirect-1265272.patch3.58 KB

Here is a patch.

I'm not used to contribute to the community so feel free to correct me (management status of the issue, code compliance, patch submission,...)

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Needs work

Your patch appears to be against an older version of the code than latest -dev and does not apply.

You should check the code out of git and use git diff to generate patches.

dimduj’s picture

dimduj CreditAttribution: dimduj commented
FileSize
302-temporary-redirect-1265272-3.patch984 bytes

Ok...
After some time discovering Git, here is a correct patch (?)

dimduj’s picture

dimduj CreditAttribution: dimduj commented
Status: Needs work » Needs review

Well I 've forget to change the status in "need review" :)

dimduj’s picture

dimduj CreditAttribution: dimduj commented

Should I do something else ?

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Sorry, be patient.

We prefer || to OR in PHP -- PHP supports the 'or' keyword but it binds differently, so we try to use it only when it's needed for the tighter binding.

Otherwise this is probably good, when I get a chance to commit it.

dimduj’s picture

dimduj CreditAttribution: dimduj commented
FileSize
303-temporary-redirect-1265272-5.patch984 bytes

Yep, sorry I should be patient..

Here is a new patch with pipes instead of OR

dimduj’s picture

dimduj CreditAttribution: dimduj commented

Hi,

Any news ?
Tell me if I should propose another version of the patch ....

Regards,

johnnydarkko’s picture

johnnydarkko CreditAttribution: johnnydarkko commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
FileSize
302-temporary-redirect-1265272-9.patch1.49 KB

Rerolled Patch in #7 for 7.x-1.x.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Assigned: dimduj » Unassigned

DamienMcKenna queued 9: 302-temporary-redirect-1265272-9.patch for re-testing.

rivimey’s picture

rivimey
she/her
CreditAttribution: rivimey as a volunteer commented
FileSize
302-temporary-redirect-1265272-12.patch1.49 KB

Reroll patch in #9 (no substantive changes) for 7.x-1.x

rivimey’s picture

rivimey
she/her
CreditAttribution: rivimey as a volunteer commented
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
ctools-n1265272-14.patch1.73 KB
ctools-n1265272-14.interdiff.txt863 bytes

Two minor comment/text adjustments.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2785697: Plan for CTools 7.x-1.11 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Reviewed & tested by the community

I'm RTBC'ing this for @dimduj and @johnnydarkko's work, my patch in #14 was insignificant.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone for helping get this somewhat old patch resolved. Committed.

  • japerry committed 92e81e1 on 7.x-1.x 
    Issue #1265272 by dimduj, DamienMcKenna, rivimey, johnnydarkko: Page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.