t() is being used less than gracefully in the Font Squirrel provider module. Let's clean it up a bit.

Files: 
CommentFileSizeAuthor
#4 0001-Follow-up-to-1255852-Fixed-typo-in-called-function-n.patch1.06 KBFreso
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 0001-Follow-up-to-1255852-Fixed-typo-in-called-function-n.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View
#1 0001-Bug-1255852-Fixed-badly-formatted-t-strings-in-Font-.patch3.34 KBFreso
PASSED: [[SimpleTest]]: [MySQL] 9 pass(es). View

Comments

Freso’s picture

Title: Badly formatted t() strings in Font Squirrel sub module » Badly formatted t() strings in Font Squirrel provider module
Status: Active » Needs review
FileSize
3.34 KB
PASSED: [[SimpleTest]]: [MySQL] 9 pass(es). View

Here you go. git am <patch name> should apply the patch. I'm guessing it should apply cleanly to 7.x-1.x as well, if not, I'll port it when it's accepted.

sreynen’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. I'll try to get this applied soon. Thanks.

sreynen’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x-2.x, 7.x-1.x and 6.x-2.x.

Freso’s picture

Status: Fixed » Reviewed & tested by the community
FileSize
1.06 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 0001-Follow-up-to-1255852-Fixed-typo-in-called-function-n.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View

Oops. You messed up in the porting to 6.x-2.x, rupal_... instead of drupal_.... Patch attached, ready to be applied with git am.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 0001-Follow-up-to-1255852-Fixed-typo-in-called-function-n.patch, failed testing.

sreynen’s picture

Status: Needs work » Fixed

Thanks so much for catching that. Fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.