Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If a user uses a version of firefox higher than 4.0, the gift are loaded to the page replacing the submit button but the images are not animated.
I just notices that this also affects Explorer 9.0 (don't know about older versions).
Any idea how to solve this?
Comment | File | Size | Author |
---|---|---|---|
#14 | 1255086_hide_submit_partial_upgrade.patch | 10.63 KB | greggles |
#14 | 1255086_hide_submit_partial_upgrade_no_whitespace.patch | 8.58 KB | greggles |
#8 | hide_submit-firefoxfix-1255086-8.patch | 1.72 KB | neilnz |
Comments
Comment #1
urbanbricks CreditAttribution: urbanbricks commentedSubscribing
Comment #2
Junro CreditAttribution: Junro commentedSame problem.
Comment #3
sapox CreditAttribution: sapox commentedSince it is 6.x, the jquery version affected is 1.2.6.
Any comment?
Comment #4
Optalgin CreditAttribution: Optalgin commentedI'm having this issue too,
It seems like firefox doesn't start animations on hidden gif images
I don't think it has nothing to do with jquery
So far I couldn't find how to solve this
Comment #5
Optalgin CreditAttribution: Optalgin commentedAt last! a solution was found (See here)
I'll commit this soon
Comment #6
Junro CreditAttribution: Junro commentedGood news :)
Comment #7
neilnz CreditAttribution: neilnz commentedAny progress on this? It's affecting us too.
Comment #8
neilnz CreditAttribution: neilnz commentedFor anyone that wants a patch, here's one that uses the answer from #5.
It works by not including the image in the string from the server, but splicing it in using DOM methods before adding it to the page.
Comment #9
sapox CreditAttribution: sapox commentedWorks quite ok for me. This needs to be committed soon.
Thanks neilnz!
Comment #10
neilnz CreditAttribution: neilnz commentedI've since discovered that this breaks the preview on the admin page and breaks the gif in IE!
I'm in the process of working on something that works in IE too.
Comment #11
saravanant-1 CreditAttribution: saravanant-1 commentedhello could you tell me how to apply this patch on linux? I tried like this, but it is failed.
saravanan@linux # patch < hide_submit-firefoxfix-1255086-8.patch
patching file hide_submit.js
Hunk #1 succeeded at 98 (offset 72 lines).
patching file hide_submit.module
Hunk #1 FAILED at 330.
1 out of 1 hunk FAILED -- saving rejects to file hide_submit.module.rej
bitnami@linux:/opt/bitnami/apps/drupal/htdocs/sites/all/modules/hide_submit$
i modified by files manually from the diff file. but the animation is not working both in IE & Firefox.
Your help is very much appreciated.
Regards,
Saravana
Comment #12
saravanant-1 CreditAttribution: saravanant-1 commentedHi,
I applied your patch. but it it not working in firefox.
Could you help how to apply this patch on linux. I did patch as below.
Comment #13
Berliner-dupe CreditAttribution: Berliner-dupe commentedSame problem here.
Patch from #8 dont work in IE or Firefox. In Chrome it works.
Has anyone an idea?
Comment #14
gregglesI took this a bit further by following coder's advice and fixing other little things as I noticed them. Attached is my patch and a "no whitespace" version made with "git diff -w". Even with these changes it still needs some more work to become functional.
There's a pretty critical problem with the administration screen right now that it doesn't save. Instead you get "An illegal choice has been detected. Please contact the site administrator."
The current module feels overly complex to me. I see no reason why it should have a feature to allow uploading the image or the "random" replacement image built into the module itself. I wonder if there should be a new 7.x branch that is much lighter weight and allows everything to be overridden by theme functions as appropriate. That would make it much easier to maintain the module (i.e. and upgrade it to new versions of core).
Comment #15
gregglesblargh. Please ignore comment #14 which was meant for #1072332: D7 port of Hide-submit-button.
Comment #16
gregglesThanks for submitting this issue.
The 6.x branch of this module is not supported. This issue was filed against the 6.x version so I'm closing it because it doesn't seem relevant to the 7.x version.
If the issue is relevant for the 7.x version: I apologize for closing it. Can you please reopen it and adjust the version number?