I propose to change

'type' => MENU_LOCAL_ACTION, (clone.module at line 50)

to

'type' => MENU_LOCAL_TASK,

as it is more handy to have "Clone" as a task tab.

Otherwise a setting letting you switch between these options could be handy.

CommentFileSizeAuthor
#11 1252702-menu-local-task.patch390 bytesDave Reid
#3 menu_local_task-1252702-3.patch331 bytesbneil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zepner’s picture

zepner CreditAttribution: zepner commented

agreed, did the same.
is there an actual purpose for keeping it in the action_links?

CarbonPig’s picture

CarbonPig CreditAttribution: CarbonPig commented

subscribe - I did the same thing - tab is more useful and doesn't clutter up a panel. Tab can also be hidden/renamed using Tab Tamer module if needed.

bneil’s picture

bneil CreditAttribution: bneil commented
Status: Active » Needs review
FileSize
menu_local_task-1252702-3.patch331 bytes

Quick patch that changes MENU_LOCAL_ACTION to MENU_LOCAL_TASK.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Issue tags: +Release blocker

I think action is more correct though. Anyway, needs committer feedback.

GiorgosK’s picture

GiorgosK
Location Chios, Greece 🇬🇷
CreditAttribution: GiorgosK commented
Status: Needs review » Closed (duplicate)

module maintainer has already answered that he won't fix it if you read #16 in #1054834: Clone tab

how about if there is a configuration choice ?
or how would we integrate into contextual links ?

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

How about we move the discussion over here: #1328682: Add a link to the contextual menu / or a tab for cloning the node

Definitely an improved UI is important.

attheshow’s picture

attheshow CreditAttribution: attheshow commented

@neuronick - Thanks for posting about the MENU_LOCAL_TASK fix. This helped me get it configured the way I wanted it.

jnettik’s picture

jnettik
Primary language English
Location Denver, CO
CreditAttribution: jnettik commented

I would second the link being in the tabs.

Hitby’s picture

Hitby
he/him
CreditAttribution: Hitby commented

Patch in #3 works well. Looks much tidier. Thanks,

sirtet’s picture

sirtet
Primary language German
Location Switzerland
CreditAttribution: sirtet commented

+1 for a setting for the link-type's tab|action|contextual

In the meantime, for people who are not comfortable with patches, there's a module for that: https://drupal.org/project/node_clone_tab

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue summary: View changes
FileSize
1252702-menu-local-task.patch390 bytes

Re-rolled patch against RC2. So confusing why this is a local action.

sirtet’s picture

sirtet
Primary language German
Location Switzerland
CreditAttribution: sirtet commented

I'd love to see this in, but it's aparently very controversal, see https://www.drupal.org/node/1328682
Maybe this issue should be closed as duplicate (and the other one reopened)?