Latest 6.x-1.x-dev causes the sending of private messages by the privatemsg module to fail silently.

Comments

AlexisWilke’s picture

Status: Active » Postponed (maintainer needs more info)

jswap,

Are you saying that older versions of the module were working as expected?

Thank you,
Alexis Wilke

karmraj’s picture

Hello guys,

I have install private message module in my site. It works worked perfectly. But after that i want to restrict some swear word to use from my site. Thats why i have install spam module. And create custom filter to restrict bad words. Its also works perfectly. But after installed spam module private messaging module does not work. So just disable spam module then again private messaging module works perfectly. So i thought there is some conflict occur b/w this two module. So please suggest any other module to restrict swear words or any patches to solve this issue.

Thanks in advance.

Karmraj.

marko3’s picture

I have exactly the same problem.
For me Privatemsg and Spam modules used to live happily together. But just after upgrading to spam 6.x-1.3 no privatemsgs can be sent/received, and sending notification does not appear anymore .When I disable spam module, privatemsgs resumes working.

I had a lot of pain to discover that the new release of spam module is the culprit if this serious issue.

Since I am heavily reliant on both modules I hope you can fix this issue soon.

Thanks for the great spam module

AlexisWilke’s picture

When you say it was working with previous version, would it with 1.2, 1.1, 1.0?

mr.j’s picture

Status: Postponed (maintainer needs more info) » Active

I just upgraded spam to 6.x-1.3 and I am seeing the same thing. Sending a private message fails silently - you submit the form and it appears to send, the only clue that it doesn't is that there is no message saying that the PM was sent.

Disabling all spam modules fixes the problem. It does not work if only Spam API is enabled (and all other spam modules disabled), so it suggests that the problem lies in spam.module.

This was not a problem with spam 6.x-1.2.

mr.j’s picture

Version: 6.x-1.x-dev » 6.x-1.3

Correct version.

mr.j’s picture

Title: Latest 6.x-1.x-dev breaks the privatemsg » 6.x-1.3 silently prevents all private messages from being sent

Are you saying that older versions of the module were working as expected?

When you say it was working with previous version, would it with 1.2, 1.1, 1.0?

From what I can see looking through our SVN, previous releases of spam never scanned private messages. As the maintainer surely you would know this?

I am mighty annoyed that this bug was lodged in August, and was immediately marked as postponed and ignored despite the fact that it would have been obvious to a maintainer that new code introduced to the module was the likely problem. Then it was allowed to be released. Now we have several days of missing PMs and a whole bunch of annoyed users. No doubt there are many other sites that don't even know they have a problem yet.

Quick fix for anyone else burnt by this - go to the /spam/content directory and either delete or rename "spam_content_privatemsg.inc" to "spam_content_privatemsg.inc.doesntwork" or something and it will stop scanning PMs and allow them to be sent again.

AlexisWilke’s picture

That was added by Killes.

You may want to contact him directly http://drupal.org/user/227 as he's probably not listening to new issues in the spam queue on a regular basis.

Thank you.
Alexis

killes@www.drop.org’s picture

I am still reading this.

I added this on behalf of a client who aborted the project halfway. Thus the private message integration was never tested and I have no incentive to fix it myself. I suggest to remove it.

AlexisWilke’s picture

Killes,

Well... that's your work 8-)

You may want to go ahead and generate a 1.4 too so people can get the "fix" from the "broken" 1.3.

Note that files don't automatically get deleted on client machines, so maybe commenting out everything for now? Would that work? And in the next version have it removed (i.e. once 1.4 was generated.)

marko3’s picture

@AlexisWilke
Sorry, I am not really sure. Since I keep the modules up-to-date, it is likely to have been 1.2. The only thing that I am sure of is that When I downgraded Spam module from 1.3 to the previous version, the Privatemsg resumed working.

AlexisWilke’s picture

Assigned: Unassigned » AlexisWilke

Alright guys... the offensive file is still in 1.4, but the whole thing is commented out. So... it should not cause this side effect anymore. If someone feels like making this work, then the existing code is certainly a good start!

Special thanks to mr.j for pointing out what the problem was!

Thank you.
Alexis Wilke

AlexisWilke’s picture

Status: Active » Fixed

Meant to set the status to "fixed".

mr.j’s picture

Thanks for the fix. In future it would be good to have an option in the UI to enable/disable these includes for contact forms, private messages etc.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.