i18strings_cache returns array for strings with objectid 0 on second call [#1241648]

i18strings_cache will return an array part of the strings array if objectid is 0 once it has been cached. In i18nstrings_cache the while loop will bail out on !empty($context->objectid) since '0' is considered empty in PHP. I worked around the issue by replacing !empty with isset, but perhaps this has other side effects. Anyhow, I got this bug by using context, the admin module with context inspector and an untranslated title for the locale language switcher block (with block delta 0), so that setup could probably be used to reproduce the bug.

Comment	File	Size	Author
#3	i18strings_cache_returns_array_for_strings_with_objectid_0_on_second_call-1241648-3.patch	723 bytes	K15.Multik
#2	i18strings_cache_returns_array_for_strings_with_objectid_0_on_second_call-1241648-2.patch	723 bytes	K15.Multik
#1	i18nstrings_get_cache_with_objectid_is_zero.patch	858 bytes	noomz

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

noomz CreditAttribution: noomz commented 26 March 2012 at 14:11

Version:	6.x-1.x-dev	» 6.x-1.10
Component:	Code	» Blocks
Priority:	Normal	» Major

File	Size
i18nstrings_get_cache_with_objectid_is_zero.patch	858 bytes

I second @gnucifer, should change to "isset" because objectid can be 0(zero) in any custom module user created. If the purpose is not allow the empty string, I think using "trim" along with "isset" should be better. See in patch.

Comment #2

K15.Multik CreditAttribution: K15.Multik commented 23 October 2013 at 09:45

Assigned:

Unassigned

» K15.Multik

File	Size
i18strings_cache_returns_array_for_strings_with_objectid_0_on_second_call-1241648-2.patch	723 bytes

In my opinion, it is additionally necessary to check whether the value is a number.
Replace !empty($context->$field) with (!empty($context->$field) || is_numeric($context->$field)).

Comment #3

K15.Multik CreditAttribution: K15.Multik commented 23 October 2013 at 09:50

Status:

Active

» Needs review

File	Size
i18strings_cache_returns_array_for_strings_with_objectid_0_on_second_call-1241648-3.patch	723 bytes

Needs review ))

Comment #4

23 October 2013 at 09:53

Status:

Needs review

» Needs work

The last submitted patch, i18strings_cache_returns_array_for_strings_with_objectid_0_on_second_call-1241648-3.patch, failed testing.

Comment #4.0

(not verified) CreditAttribution: commented 23 October 2013 at 09:53

Issue summary:

View changes

clarification

Comment #5

oliverpolden CreditAttribution: oliverpolden commented 3 January 2014 at 16:18

I can confirm I've seen this issue. The patch in #3 works for me.

I've also had a look at the reasons the tests have failed for the patch. I'm not sure exactly how to interpret it but it looks like the test is failing to log in however I've locally tested logging in with a translated block and it works fine.