Views row options missing in views export [#1240510]

Hi @all,

I just mentioned that a view using the Display suite row plugin lacks the "Grouping data" settings during export. The "grouping" option is exportet, but "group_field" and "group_field_function" are not.

This leads to the following error, when the view is packaged in a feature and enabled on a fresh install:
Undefined index: grouping_fieldset in views_plugin_ds_entity_view->render()

I'd appreciate if someone may have a look at this problem...

Thanx in advance & cheers

hctom

Comment	File	Size	Author
#10	ds-1240510-10.patch	2.24 KB	tim.plunkett
#9	ds-1240510-9.patch	2.13 KB	tim.plunkett
#4	ds-1240510-4.patch	1.7 KB	tim.plunkett
#1	1240510.patch	741 bytes	swentel

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

swentel CreditAttribution: swentel commented 5 August 2011 at 15:29

Title:	Views grouping data settings of Displa suite row plugin partially missing in views export	» Views row options missing in views export
Status:	Active	» Needs review

File	Size
1240510.patch	741 bytes

looks like every sub option was actually missing. Can you test with the attached patch, should fix it.

Comment #2

swentel CreditAttribution: swentel commented 7 August 2011 at 13:45

Status:

Needs review

» Fixed

I went ahead and committed this. I'll be adding tests for ds views integration at #1241936: Missing tests - in case there are still issues with this, add them to that issue.

Comment #3

21 August 2011 at 13:52

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #4

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 9 November 2011 at 01:43

Status:

Closed (fixed)

» Needs review

File	Size
ds-1240510-4.patch	1.7 KB

I had to decide between reopening this or #1241936: Missing tests and opening a new issue. Hope this is okay.

option_definition() has to know about everything, event the nested stuff.
I'm not sure about the difference between $options['grouping'] and $options['grouping_fieldset']['grouping'] though.

Comment #5

swentel CreditAttribution: swentel commented 9 November 2011 at 08:46

Status:

Needs review

» Needs work

Hmm didn't know about that 'contains' key, interesting. The 'grouping' key is the checkbox to disable/enable that feature, fieldset is anything underneath it.

+++ b/views/views_plugin_ds_entity_view.inc
@@ -42,10 +42,35 @@ class views_plugin_ds_entity_view extends views_plugin_row {
+        'item_0' => array('default' => 'full'),
+        'item_1' => array('default' => 'full'),
+        'item_2' => array('default' => 'full'),
+        'item_3' => array('default' => 'full'),
+        'item_4' => array('default' => 'full'),

This set of items is dynamic depending on the pager limit. So this is hardcoded now. I'll have a look at it this weekend to make it dynamic.

Comment #6

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 9 November 2011 at 12:58

Views is smart enough to not export default values, I just put everything into options_definition until the export looked clean. And yeah, I had a 5 item pager, makes sense.

Comment #7

swentel CreditAttribution: swentel commented 9 November 2011 at 13:33

So whether we put 1 or 10 default items, that doesn't really matter there ?

Comment #8

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 9 November 2011 at 13:46

No, to the contrary. If we put one there, but there are 10 in the options_form, the last 9 of them will go into every export. Perhaps we'd need to do some introspection into the pager during options_definition, but I don't know that it works like that.