Notice: Undefined property: stdClass::$workbench_moderation in workbench_moderation_node_history_view() [#1238428]

This error pops up on the Moderation tab and prevents the moderation interface from being displayed. I suspect it is the result of node caching, since it goes away when the caches are cleared, but will pop up again after about 5-10 minutes of content editing on the site. In situations where this error arises, hook_node_load() is not being called, which means that $node->workbench_moderation is not set. It appears that the vast majority of functions assume that hook_node_load() is being called every time, because they do not call workbench_moderation_node_data() and they do not check to make sure that $node->workbench_moderation exists before trying to use it.

While this may only be treating the symptom of a deeper issue, I've rolled the attached patch, which addresses this specific situation (node_history_view()). Since installing it I have not run into any other such errors on my own sites, but I think it might be worthwhile to do a bit more property checking and/or error handling.

Comment	File	Size	Author
#1	workbench_moderation-undefined-property-1238428.patch	551 bytes	Déja
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Déja CreditAttribution: Déja commented 3 August 2011 at 17:21

Status:

Active

» Needs review

File	Size
workbench_moderation-undefined-property-1238428.patch	551 bytes

Comment #2

3 August 2011 at 18:02

Status:

Needs review

» Needs work

The last submitted patch, workbench_moderation-undefined-property-1238428.patch, failed testing.

Comment #3

becw CreditAttribution: becw commented 5 August 2011 at 22:02

Priority:	Major	» Normal
Status:	Needs work	» Postponed (maintainer needs more info)

Déja, can you describe how to make this bug happen? It seems like your patch will address the issue you describe, but I'm wary of working on an issue I can't duplicate--I never know when it's fixed :)

Also, I don't know what's up with the tests. It looks broken in ways that are unrelated to the patch you posted.

Comment #4

Déja CreditAttribution: Déja commented 11 August 2011 at 18:32

The only site I've encountered this issue on was one in which I had migrated several thousand nodes across a half-dozen content types from Drupal 5 into Drupal 7. I have not had an opportunity to try to recreate it on a clean install.

Comment #5

stevector

he/him

CreditAttribution: stevector commented 28 October 2011 at 17:26

Status:

Postponed (maintainer needs more info)

» Closed (cannot reproduce)

I'm going to close this because we haven't gotten any other reports of the problem and cannot reproduce it. Please re-open if you see it again.

Comment #6

Elin Yordanov CreditAttribution: Elin Yordanov commented 7 May 2013 at 11:11

I had a similar issue today and I come up to this page. Although no solution is posted since the issue was not reproducable, the statement of the OP:

I suspect it is the result of node caching

has given me the light, since I had the 'Entity Cache' module installed. After disabling Entity Cache the notices are gone away.

Comment #7

dend01 CreditAttribution: dend01 commented 17 June 2013 at 13:18

I've had the exact same error. The notices only go away once I clear my caches. But they inevitably come back. I'm not sure what to do to. Any suggestions would be much appreciated.

Comment #8

dend01 CreditAttribution: dend01 commented 17 June 2013 at 13:24

A little more precision. I usually get a series of error messages. Here are some examples:

Notice: Undefined property: stdClass::$workbench_moderation in _workbench_moderation_access_current_draft() (line 570 of /home/vg007web05/14/65/2016514/web/sites/all/modules/workbench_moderation/workbench_moderation.module).

Notice: Undefined property: stdClass::$workbench_moderation in workbench_moderation_view_tab_title() (line 337 of /home/vg007web05/14/65/2016514/web/sites/all/modules/workbench_moderation/workbench_moderation.module).

Notice: Undefined property: stdClass::$workbench_moderation in workbench_moderation_edit_tab_title() (line 305 of /home/vg007web05/14/65/2016514/web/sites/all/modules/workbench_moderation/workbench_moderation.module).

Comment #9

emudojo CreditAttribution: emudojo commented 2 February 2014 at 18:33

same here, while using MSSQL weird

Notice: Undefined property: stdClass::$workbench_moderation in workbench_moderation_view_tab_title() (line 337 of C:\inetpub\wwwroot\site\sites\all\modules\contrib\workbench_moderation\workbench_moderation.module).
Notice: Undefined property: stdClass::$workbench_moderation in _workbench_moderation_access_current_draft() (line 570 of C:\inetpub\wwwroot\site\sites\all\modules\contrib\workbench_moderation\workbench_moderation.module).
Notice: Undefined property: stdClass::$workbench_moderation in workbench_moderation_edit_tab_title() (line 305 of C:\inetpub\wwwroot\site\sites\all\modules\contrib\workbench_moderation\workbench_moderation.module).

Comment #10

iLLin CreditAttribution: iLLin commented 25 April 2014 at 20:40

Issue summary:

View changes

Using views bulk operations, it does not load the full node into the $node variable during the presave function. To fix this issue, we need to load the node object manually. This can be fixed like so to start on line 657.

function workbench_access_node_presave($node) {
  // We must have a node id to continue. @see workbench_access_node_insert().
  if (empty($node->nid)) {
    return;
  }
  // Load full Node object
  $node = node_load($node->nid);

There may be a better method, so not providing a patch yet.

Comment #11

iLLin CreditAttribution: iLLin commented 25 April 2014 at 20:36

Status:

Closed (cannot reproduce)

» Active

Comment #12

iLLin CreditAttribution: iLLin commented 25 April 2014 at 20:39

Project:

Workbench Moderation

» Workbench Access

And the module in question is Workbench Access, so moving this issue.

Comment #13

giri99 CreditAttribution: giri99 commented 28 December 2014 at 02:06

I got the same error, is there any update with the issue??

Comment #14

vids CreditAttribution: vids commented 13 May 2015 at 19:01

I got the same error while I updated the module 1.4

Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).
Notice: Undefined property: stdClass::$is_current in workbench_moderation_node_data() (line 1230 of /mnt/www/html/example.com/docroot/sites/all/modules/workbench_moderation/workbench_moderation.module).