generalize node_form_delete_submit() to a FormAPI helper [#1236780]

http://api.drupal.org/api/drupal/modules--node--node.pages.inc/function/... is a submission handler for the 'Delete' button on a node edit form. All it does is redirect the user to a specific path, where the node delete confirmation form is available.

The patch at #1199428: Incremental UX improvements to Field UI adds an almost identical submission handler to the Field admin form.

Taxonomy term admin forms would ideally need a similar pattern (see http://drupal.org/node/949616#comment-4199948 for more about the mess in term edit forms at the moment).

So it seems that we're going to be peppering core with almost identical form submission handlers, that merely move the user to another form. Perhaps FormAPI could provide a helper function here?

Comment	File	Size	Author
#1	1236780.drupal.form-redirect-helper.patch	2.33 KB	joachim
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joachim CreditAttribution: joachim commented 2 August 2011 at 12:58

Status:

Active

» Needs review

File	Size
1236780.drupal.form-redirect-helper.patch	2.33 KB

Here's a patch.

Start your bikesheds on the function name, please!

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost commented 9 August 2011 at 23:24

Maybe just extent #redirect key for submit element to make no function at all? And make FormAPI process #redirect key properly

Comment #3

joachim CreditAttribution: joachim commented 10 August 2011 at 06:34

I like the idea of putting #redirect deeper in FormAPI, but for this sort of use you'd still need to specify a #submit for the Delete button to avoid going to the regular submit function.