Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Now the rev log message by default is "edited by [user]"
That is not useful.
Could it be customizable?
For me, I just want it to be blank by default, as I am using "enforce rev log message" module to force user to leave a log message. But if I got some default text, user can save it without leave a message.
Comment | File | Size | Author |
---|---|---|---|
#55 | Issue-1233810-by-hass-Customizable-revision-log-mess.patch | 4.37 KB | hass |
Comments
Comment #1
robeano CreditAttribution: robeano commentedI'll take this one.
Comment #2
robeano CreditAttribution: robeano commentedWe should provide a minimum length setting as well. See #1283814-2: Does Workbench support - Mandatory Revisions with Notes?.
Comment #3
HyperGlide CreditAttribution: HyperGlide commented@robeano thanks for taking this!
Pls advise if need me to help test.
Comment #4
stevectorTagging and relating to #1316314: Workflow Architecture for Workbench Moderation
Comment #5
stevectorI think this should be in any 2.x re-architecting.
I'm open to patches for 1.x that make this a setting. In 1.x I suppose it could be per-node-type and shoe horned onto the node type edit page. Or it could be global to all nodes under Workbench Moderation.
Comment #6
HyperGlide CreditAttribution: HyperGlide commentedhello -- any thoughts on how http://drupal.org/project/better_revisions would interface or work with WB-Moderation?
We are still struggling with the quality of revision notes from users.
Comment #7
dayofthedave CreditAttribution: dayofthedave commentedNot sure if this falls outside the scope of the feature request, but it would be nice if it could also include the functionality of the "enforce rev log message" module. I think most anyone who opts for a blank default message would also want to prevent blank messages from being submitted.
Comment #8
dayofthedave CreditAttribution: dayofthedave commentedThis worked for me. Sorry if it's not a proper patch file. I've never submitted one before, so I'm not 100% sure if this is the right format.
Comment #9
HyperGlide CreditAttribution: HyperGlide commentedI would also suggest looking at #1727242: Compatibility with WorkBench Moderation.
Comment #10
TechNikh CreditAttribution: TechNikh commented#8 worked for me
Comment #11
colan#8 is a good place to start, but there should be an option to turn it off. Also, there's extra whitespace at the end of the last line (minor).
Comment #12
colanBetter title.
Comment #13
texas_taterHi Folks,
I'm having the same issue as Eric Yang, almost 4 years to the day of his original post here!
How can I REMOVE the default rev log message of "edited by [user]"? I'm desperate to begin using "enforce rev log message" module, but it's moot with a default message in there.
As for the "edited by user info", I'm using WB with Revisioning module (we use Diff to compare revisions), so I already have that info coming thru via Revisioning display.
So, not only is the "edited by [user]" default message taking up valuable space for more useful info, but it's duplicate info to boot.
ANY insights/guidance on how I can simply REMOVE that default text is GREATLY appreciated!
Comment #14
das-peter CreditAttribution: das-peter at Cando commentedI guess this has to go back to 1.x since 2.x doesn't have such a message anymore.
Comment #15
kurtfoster CreditAttribution: kurtfoster commentedI've created a new patch and it's working well for me. It allows the user to select either update or create message or both in the admin form for the module. Then shows / hides the log message as appropriate.
Comment #16
tclark62 CreditAttribution: tclark62 commentedFor those of you who were unable to immediately locate where the options in patch #15 were added, they were added in Workbench Moderation > Advanced.
This works for me, however, for some reason the options are actually reversed. So that when "Auto Revision Log on Create" is unchecked and "Auto Revision Log on Update" is checked, nodes which are being updated no longer have an automatic revision message while newly created nodes do. This is also true of the opposite situation as well.
I don't understand why this is the case, but it's definitely happening. I've cleared all my caches, made sure there were no db updates, but to no avail. I tried deducing if there is an error in the patch, but the patch seems to be doing the correct things, but then again I also only briefly glanced at it.
Good work on providing these options, though, @kafmil.
Comment #17
tclark62 CreditAttribution: tclark62 commentedFound the problem. Two variables were swapped at a point I didn't see.
Comment #18
hass CreditAttribution: hass commenteducfirst only
How about adding some
<em>
(or double quotes) around the "Created by [username]".ucfirst only
Same as before
[user:name]
and[user:name-raw]
token if Realname is used.Comment #19
tclark62 CreditAttribution: tclark62 commentedThanks for looking at this @hass.
I made the first four changes. Unfortunately, I'm not familiar enough with uninstalling variables to add that piece.
The second point you suggest (about requiring revisions) is accomplished by a module like Enforce Revision Log, so that seems out of the scope here. Why duplicate existing functionality? But maybe I didn't understand your point as you intended.
And again, my knowledge prohibits me from being able to speak to your third bullet point.
Comment #20
hass CreditAttribution: hass commentedhttps://www.drupal.org/project/enforce_revlog does not work with workbench moderation per project home. Never heard of this module yet... Just thought why i need an extra module for this simple feature. If i find some time I will try to look into the token stuff and update the code. Should be quite simple.
Comment #21
tclark62 CreditAttribution: tclark62 commentedSounds great! Thanks again.
Just so you know, I'm pretty sure that, with this issue patched, EnfRevLog would work with Workbench Moderation. I say that because of what's detailed in this issue and because I'm actually using it in conjunction with Workbench Moderation and it works fine with this patch.
Comment #22
hass CreditAttribution: hass commentedAh, ok. Now I understand the project home comment. I thought it is a real difficulty.
Comment #23
hass CreditAttribution: hass commentedHere is a patch that works well here. It also applies to 7.x-3.x. Please RTBC.
Comment #26
hass CreditAttribution: hass commentedAdded token module for test bot.
Comment #29
hass CreditAttribution: hass commentedComment #30
hass CreditAttribution: hass commentedComment #33
hass CreditAttribution: hass commentedreuploading
Comment #36
hass CreditAttribution: hass commentedComment #39
hass CreditAttribution: hass commentedTests run fine locally. No idea what the problem is.
Comment #40
hass CreditAttribution: hass commentedComment #43
hass CreditAttribution: hass commentedComment #46
hass CreditAttribution: hass commentedI think I cannot fix this as the dependency need to be added to the module first and after 24h the tests will download token module first.
Comment #49
hass CreditAttribution: hass commentedComment #50
larowlanI will contact the 7.x maintainer and ask if they have an objection to committing the token dependency to 7.x-2.x HEAD
Comment #51
hass CreditAttribution: hass commented7.x-3.x
Comment #52
hass CreditAttribution: hass commentedEDIT: I should not manually delete a line from a git patch.
Comment #55
hass CreditAttribution: hass commentedAfter some thinking... I missed that
token_replace()
is a core function and[user:name]
always work in core. This patch makes token module just optional to enhance the UI.Applies to 1.x and 3.x.
Comment #56
hass CreditAttribution: hass commentedComment #57
larowlanDo we need a test here - question for the 7x branch maintainer?
Other than that, looks good to me.
Comment #58
agentrickardLooks good. I like the compromise of Token as a soft dependency.
Comment #59
hass CreditAttribution: hass commentedSounds like a maintainers RTBC approval