Editing nodes - Purge-command to Varnish not working anymore

I can confirm the problem exists in "7.x-1.x-dev" datestamp = "1311295316".

I compared with varnish.module for Drupal 6.x and there we had hook_comment and hook_nodeapi like:

function varnish_nodeapi(&$node, $op) {
    // We've probably just run through node_save, and normally this is where
    // Drupal calls a cache_clear_all().
  if (in_array($op, array('insert', 'update', 'delete', 'delete revision'))
    && variable_get('varnish_cache_clear', VARNISH_DEFAULT_CLEAR) == VARNISH_DEFAULT_CLEAR) {
        varnish_purge_all_pages();
  }
}

/**
 * Implementation of hook_comment()
 *
 * Used to pick up cache_clearing events
 */
function varnish_comment($comment, $op) {
  if (in_array($op, array('insert', 'update', 'publish', 'unpublish', 'delete'))
    && variable_get('varnish_cache_clear', VARNISH_DEFAULT_CLEAR) == VARNISH_DEFAULT_CLEAR) {
        varnish_purge_all_pages();
  }
}

Shouldn't the corresponding Drupal 7 hooks be added to fix this?

I've fixed part of the problem. Sorry if I don't submit a patch in the proper way, I haven't had the time to read the docs for git yet.

You just need to add these functions to varnish.module:

/**
 * Implements hook_node_insert().
 */
function varnish_node_insert($node) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_node_update().
 */
function varnish_node_update($node) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_node_delete().
 */
function varnish_node_delete($node) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_node_revision_delete().
 */
function varnish_node_revision_delete($node) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_comment_insert().
 */
function varnish_comment_insert($comment) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_comment_update().
 */
function varnish_comment_update($comment) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_comment_delete().
 */
function varnish_comment_delete($comment) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_comment_publish().
 */
function varnish_comment_publish($comment) {
  varnish_purge_all_pages();
}

/**
 * Implements hook_comment_unpublish().
 */
function varnish_comment_unpublish($comment) {
  varnish_purge_all_pages();
}

This is the same approach used by the Varnish module for Drupal 6 and considers cases when a node or its comments change. I haven't considered the case for purging user profiles as I don't need that part for now but should be easy to add if you take a look at the 6.x module.

I'd prefer calling a function like this instead of purging all pages just because one node has changed:

function varnish_purge_node($nid) {
  if (variable_get('varnish_cache_clear', VARNISH_DEFAULT_CLEAR) == VARNISH_DEFAULT_CLEAR) {
    $paths = array(drupal_get_path_alias('node/' . $nid));
    varnish_expire_cache($paths);
  }
}

but that adds some complexity to the logic as this code only purges the url where the full node is displayed but parts of a node, probably the teaser or title, can appear on other pages and those url's should be purged from Varnish as well.

I'm wondering if the module developers are thinking of a different approach and if that was the reason to remove this logic from the latest development code.

Here's a patch based on #4- it's not an ideal solution, but it's better than nothing.

Should the status be changed to needs review?

Or is the patch in post #6 ugly enough that a rewrite is needed?

This should not be needed in the Drupal 7 version. The new version works as a Drupal Cache backend, which means it will fetch all calls to cache_clear_all() automaticly. This means that the cache will be cleared automaticly by Drupal core.

If you need more granular cache invalidation, you can turn this feature off and build it yourself, or try the Expire module, which is supported by Varnish.

I ran the tests, and they indicate that everything should be working as they should. I also tried the module out by testing it manually and when it's properly configured, it works as expected. For information on how to set this up, see the project page.

I'm setting this to postponed, in case there was some use case I missed.

I had this issue when varnish cron was enabled. This #1461792: Cache doesn't clear if "varnish_flush_cron" set to 1 fixed it.

It seems that in my case, this is my fault for not RTFM... I just needed to add Varnish as a caching backend as described in the README file:

<?php
// Add Varnish as the page cache handler.
$conf['cache_backends'] = array('sites/all/modules/varnish/varnish.cache.inc');
$conf['cache_class_cache_page'] = 'VarnishCache';
?>

Closing issues that had no activity the latest year, please re-open if the issues is still relevant.