Many of the help files have incorrect line endings (CRLF instead of LF):

  • help/alter-exposed-filter.html
  • help/drush.html
  • help/get-total-rows.html
  • help/other-help.html
  • help/select-multple-nids-contextual-filters.html
  • help/semantic-views.html
  • help/taxonomy-page-override.html
  • help/top-pager.html
  • help/ui-crashes.html
CommentFileSizeAuthor
#1 views-n1231868.patch22.95 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
views-n1231868.patch22.95 KB

Here's a quick patch to fix those files.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Assigned: Unassigned » esmerel

Assign for esmerel

corbacho’s picture

corbacho CreditAttribution: corbacho commented

Many of these help files are encoded in ANSI (Windows) instead of UTF-8

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Well i'm not 100% sure but wouldn't this be solved automatically by this patch?

corbacho’s picture

corbacho CreditAttribution: corbacho commented

mmm.. I'm confused now. I thought it was a convention to use utf8 encoding in Drupal, but now I don't seem to find any document that proves that.

Plus, if I download (drush dl drupal) and check with 

file -i cron.php in Ubuntu (or with Notepad ++ in Windows 7)  they show that most Drupal files are us-ascii-encoded instead of utf-8. MAINTAINERS.TXT and other files are utf-8 though.

Conclusion: forget about my comments, the end of lines are the important thing.
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed this patch to 7.x-3.x, but sadly it doesn't apply anymore to 6.x-3.x

Maybe there is some kind of script to run to update these files?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Just edit each file with an editor that's forced to save in UNIX format, i.e. open the file, add a space, remove the space, hit save, repeat.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Issue summary: View changes
Status: Patch (to be ported) » Closed (outdated)

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed: #3030347: Plan to clean process issue queue