We might consider using a section or an article tag for the wrapper.

Relates to : #1189816: Convert comment.tpl.php to HTML5

http://www.w3schools.com/html5/tag_article.asp

CommentFileSizeAuthor
#7 comment-wrapper-1229434.patch798 bytesJeff Burnz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jessebeach’s picture

Title: Convert comment.tpl.php to HTML5 » Convert comment-wrapper.tpl.php to HTML5

Derp, forgot to change comment.tpl.php to comment-wrapper.tpl.php.

jessebeach’s picture

Issue tags: +html5

added html5 tag

Jacine’s picture

Issue tags: +HTML5 Sprint: August 2011 - 1

tagging!

Jeff Burnz’s picture

Status: Active » Needs review
FileSize
798 bytes

section seems to make sense, nodes and comments as articles, with section as the wrapper,

<article class="node">
  <h1>Node Title</h1>
  
  <section id="comments">
    <h2>Comments</h2>
    <article class="comment">
      <h3>Comment Title</h3>
    </article>
  </section>
 
</article>
Lars Toomre’s picture

There is another double >> in the line:

+<section id="comments" class="<?php print $classes; ?>"<?php print $attributes; ?>>

Rereading carefully, skip the above... But now am wondering if print $attributes includes a space before first attribute if $attributes is not empty.

Jeff Burnz’s picture

Only thing actually changed is the element (swapped div for section), everything else is the same.

Anonymous’s picture

Status: Needs review » Reviewed & tested by the community

Tested and this works (when using Seven theme).

It makes sense to use section for this, it is an area of content that has a heading but that doesn't make sense as an article.

RTBC

Jacine’s picture

Issue tags: +HTML5 Sprint: August 2011 - 2

Sweet! Nice work guys ;)

This is still RTBC, just updating the sprint tag to keep track of it while we wait.

Dries’s picture

Committed to 8.x. Thanks.

Jeff Burnz’s picture

Status: Reviewed & tested by the community » Fixed

Assuming fixed? Hooray, my first patch for Drupal 8 - very chuffed :)

Jacine’s picture

Sweet! Congrats Jeff :D

jessebeach’s picture

congrats Jeff!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

cosmicdreams’s picture

I see that the comment section still has an "id='comment'" attribute. Did we want to eliminate the use of ids in our markup or am I remembering that wrong.

Jeff Burnz’s picture

Removing ID's is a totally separate issue, I dont know if there is an open issue for this.

Jacine’s picture

Nothing else needs to be done here. #comments ID is a useful anchor that we shouldn't remove IMO.

Jacine’s picture

Component: comment.module » markup
Issue tags: -HTML5 Sprint: August 2011 - 1, -HTML5 Sprint: August 2011 - 2

Cleaning up tags/component.

Jacine’s picture

Issue summary: View changes

added cross link to comment.tpl.php conversion issue