Based on discussion in #1188430: Rip out textgroup support from locale module, we need to postpone the commit of the update function to ensure it gets "tested" = run in a test update. However, the functionality removal is pretty important to make happen soon because lots of other work depends on it being gone. We don't want to spend time tossing around code that is going to be removed in refactorings. Read the full discussion in #1188430: Rip out textgroup support from locale module.

Postponing this one on #1182290: Add boilerplate upgrade path tests.

Parent issue

#1260628: META: Better translation management API in locale module

Files: 
CommentFileSizeAuthor
#5 update_for_textgroup_removal-3.patch992 bytesc960657
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/locale/locale.install. View
#4 update_for_textgroup_removal-2.patch967 bytesc960657
FAILED: [[SimpleTest]]: [MySQL] 33,987 pass(es), 2 fail(s), and 1 exception(es). View
#1 update_for_textgroup_removal.patch851 bytesGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch update_for_textgroup_removal.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View

Comments

Gábor Hojtsy’s picture

FileSize
851 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch update_for_textgroup_removal.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View

Patch.

Gábor Hojtsy’s picture

Issue tags: +D8 upgrade path, +D8MI
Gábor Hojtsy’s picture

c960657’s picture

Status: Postponed » Needs review
FileSize
967 bytes
FAILED: [[SimpleTest]]: [MySQL] 33,987 pass(es), 2 fail(s), and 1 exception(es). View

Reroll of Gabor's patch. I suspect this issue is what is causing the test bot to barf on my patch for #746240: Race condition in locale() - duplicates in {locales_source}.

c960657’s picture

FileSize
992 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/locale/locale.install. View

Status: Needs review » Needs work

The last submitted patch, update_for_textgroup_removal-3.patch, failed testing.

c960657’s picture

I think the test bot problem is due to #1336170: Add locale module to upgrade tests.

Gábor Hojtsy’s picture

@c960657 you are right. I've just posted a combined patch at http://drupal.org/node/1336170#comment-5285748 to prove that it fixes the issue (apart from manually going through all the schema details and confirming it is equal to D7). I think the update itself will be committed here, I just cross-posted there for testing, so keeping this open.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
Gábor Hojtsy’s picture

Status: Needs review » Closed (duplicate)

Ha, this was committed as part of #1336170: Add locale module to upgrade tests already.

Gábor Hojtsy’s picture

Issue tags: +language-base

Tagging for base language system.

Gábor Hojtsy’s picture

Issue tags: +language-ui

Adding UI language translation tag.

Gábor Hojtsy’s picture

Issue tags: -language-base

Language-base is not applicable here.

Gábor Hojtsy’s picture

Issue tags: +language-config

Tagging for config leg of D8MI.

Gábor Hojtsy’s picture

Issue summary: View changes

Add parent