Currently, the login link is reset to the client user's UID only during site install. Since clients don't have permission to create "reset login" tasks, this is not an issue with default Aegir installs. However, if such a permission is granted, it might be possible for the client to gain access to UID1 on their site.

This needs testing to verify that it is indeed a threat.

#1206414: Refactor to use proper Provision Drush hooks should make fixing this easier, since we'll be hooking into the provision tasks, rather then the post_install hook we're currently using.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ergonlogic’s picture

Status: Active » Postponed (maintainer needs more info)

As I noted above, "This needs testing to verify that it is indeed a threat."

anarcat’s picture

Issue summary: View changes
Priority: Normal » Minor
Status: Postponed (maintainer needs more info) » Needs work
FileSize
1011 bytes
1.04 KB

So this was actually reported to the security team. We determined it was not a security issue that deserved the traditionnal embargo because (a) it has been reported here a long time ago and (b) if a user has access to a site, they can already perform other destructive operations on it, and therefore this is a problem in certain isolated use cases.

We nevertheless see this as a bug that should be fixed, and I attach helmo's patches to fix the problem here.

anarcat’s picture

Status: Needs work » Needs review

So what actually need to happen next here? The patches look fine to me...

helmo’s picture

Just commit it I guess?

anarcat’s picture

Status: Needs review » Fixed

done.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.