So I added relationship "Node from view" to node page and it does not work in latest -dev.

in function views_content_node_from_view_context (ctools\views_content\plugins\relationships\node_from_view.inc) there is line $row = intval($conf['row']) - 1; and dsm tells me it is "-1". Not good. Turns out $conf passed to this function has no ['row'].

Am I doing something wrong or its a bug?

CommentFileSizeAuthor
#3 ctools-node_from_view-upgrade_context_plugin-1217916-2.patch878 byteshenrijs.seso
#3 ctools-term_from_view-upgrade_context_plugin-1217916-2.patch883 byteshenrijs.seso
#3 ctools-user_from_view-upgrade_context_plugin-1217916-2.patch879 byteshenrijs.seso

Comments

henrijs.seso’s picture

henrijs.seso commented

I saw in NodeOne screencast that there is row checkboxes in Relationship config screen, there were none on mine, are those removed in later versions or I should look there first?

Looks like function views_content_node_from_view_settings_form is ignored, not called at all.

henrijs.seso’s picture

henrijs.seso commented
Title: $conf missing ['row'] » Wired form problem in node_from_view.inc

Code looks legit. I have no idea where the problem could be. Brutal $row = 0; does work. There is 'settings form' in $plugin array, shouldn't it be 'edit form'?

Update from UPGRADE.txt: "Context, argument and relationship plugins now use 'add form' and/or 'edit form' rather than 'settings form'." I see. Key word in this is "now" :)

henrijs.seso’s picture

henrijs.seso commented
Status: Active » Needs review
StatusFileSize
new ctools-user_from_view-upgrade_context_plugin-1217916-2.patch879 bytes
new ctools-term_from_view-upgrade_context_plugin-1217916-2.patch883 bytes
new ctools-node_from_view-upgrade_context_plugin-1217916-2.patch878 bytes

Wonder if I should change function names too. Works without it.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

More stuff missed in the upgrade. Thanks for finding this!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.