I used a machine name "default" for my default page display, and it wiped out that display because of duplicate entry.

CommentFileSizeAuthor
#5 1212916-validate-display-id-big.patch647 bytesdawehner

Comments

drjonez’s picture

drjonez commented

FYI, using Views 6.x-3.x-dev (2011-Jun-25) - will update to the latest one (jul7) soon.

This isn't that critical for me, as I had other displays that had most of the same data. But I did have to rebuild some things. Just have to remember not use "default" as the machine name for a page display.

Thanks for all your hard work everyone!

merlinofchaos’s picture

merlinofchaos commented
Category: task » bug

Ok yes that's a bug, we should be validating that you don't try to change a display's machine name to one that already exists.

drjonez’s picture

drjonez commented
Category: bug » task

It actually does validate for ones that do exist... duplicate names are caught... unless you use "default"

hopefully an easy fix, i haven't had time to dig into the code to investigate, but I thought I'd report.

drjonez’s picture

drjonez commented
Category: task » bug
dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1212916-validate-display-id-big.patch647 bytes

'default' is already checked, the problem is that you wrote it with big letters. Views currently allowed this.

Changed this here.l

trevortwining’s picture

trevortwining commented

Testing this now...

* Created a new view, set up some basic settings in the defaults. (node display, sort by date)
* Created a new display (block). Called it 'default'. Received error "Display id should be unique."
* Machine-Named the display 'block1', saved the view. Save happens okay.
* Edited the display again and tried to change machine name to 'Default.' Received same error as above.

Based on this it looks as if the patch works as advertised.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Thanks for testing it out! Commited to 7.x-3.x and 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

wanted to remove views info for security purposes.