This is similar to #806232: Site Information Improvements which is marked as fixed, but the issues still remain.

It would be nice if we could find a true home for these items - removing them from the site information page. I couldn't find another issue that moved these things back on to the site information page, but I do like the idea of adding a "Front page settings" option under structure and would love to revisit the idea in D8.

CommentFileSizeAuthor
#21 move_front_page_error-1201580-21.patch16.02 KBdelzhand
#20 move_front_page_error-1201580-20.patch15.96 KBdelzhand
#16 move_front_page_error-1201580-16.patch12.49 KBdelzhand
#15 drupal-move_error_page_settings-1201580-15.patch9.63 KBdelzhand
#6 front-error-pages-settings.1201580.006.patch6.39 KBkarschsp
#4 front-error-pages-settings.1201580.004.patch3.36 KBkarschsp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

karschsp’s picture

karschsp CreditAttribution: karschsp commented

Should we change "Front page" to "Homepage"? "Front page" is so, I don't know, Microsoft circa 1999? I think people would maybe understand "Homepage" better, but I could be wrong.

I could see admin/structure/homepage as a possibility, but would that adequately describe the 403/404 settings?

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented

No, I think 403/404 don't belong in site information or home page settings. Perhaps a place of their own?

karschsp’s picture

karschsp CreditAttribution: karschsp commented

How about a new section called Home and Error Pages.

Or Front and Error Pages?

karschsp’s picture

karschsp CreditAttribution: karschsp commented
Status: Active » Needs review
FileSize
front-error-pages-settings.1201580.004.patch3.36 KB

OK, renaming "Front page" to "Home page" should probably be a separate issue. Here's a patch that creates a "Front and Error pages" menu item under admin/config/system.

karschsp’s picture

karschsp CreditAttribution: karschsp commented

Yeah, that's gonna fail. /me scrambles to write some tests.

karschsp’s picture

karschsp CreditAttribution: karschsp commented
FileSize
front-error-pages-settings.1201580.006.patch6.39 KB

Here's a patch with updated tests.

lambic’s picture

lambic CreditAttribution: lambic commented

Should there also be something on the node edit page? Something like "Set this node as the home page"?

karschsp’s picture

karschsp CreditAttribution: karschsp commented

@lambic, I think that would just confuse things. What if you marked 2 (or more) nodes as "Set this node as the home page"? Which one wins? And then how do you track down the others that you no longer want to be marked as the home page?

lambic’s picture

lambic CreditAttribution: lambic commented

@karschsp - When I said "node edit page" I meant when editing a single node. I think setting the node currently being edited/created as the home page would immediate override whatever node was set to the home page before (probably with some confirmation page saying "Node X is already set as the home page, are you sure you want to replace it with node Y?")

However, my suggestion is just an added convenience for the average user. We would still need the settings page for situations where the front page isn't actually a node.

karschsp’s picture

karschsp CreditAttribution: karschsp commented

#6: front-error-pages-settings.1201580.006.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, front-error-pages-settings.1201580.006.patch, failed testing.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented

Also see #1201592: Front page settings cleanup for more cleanup being done on front page settings.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Front page & Error page settings are not "Site information" » Move Front page & Error page settings out of "Site information" and into their own respective config pages.

Giving this a friendly bump. We seemed to have Dries' consent in #806232: Site Information Improvements about this needing to happen.

delzhand’s picture

delzhand CreditAttribution: delzhand commented
Assigned: Unassigned » delzhand
Issue summary: View changes
delzhand’s picture

delzhand CreditAttribution: delzhand commented
FileSize
drupal-move_error_page_settings-1201580-15.patch9.63 KB

Patch created for this. Creates a new router item and form class. I suspect there are tests to be updated as well.

delzhand’s picture

delzhand CreditAttribution: delzhand commented
FileSize
move_front_page_error-1201580-16.patch12.49 KB

Sorry, missed the front page setting. I also searched for AccessDeniedTest and couldn't find it - it's probably been renamed since. If the tests fail it should point me in the right direction, though.

delzhand’s picture

delzhand CreditAttribution: delzhand commented
Status: Needs work » Needs review

The last submitted patch, 15: drupal-move_error_page_settings-1201580-15.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 16: move_front_page_error-1201580-16.patch, failed testing.

delzhand’s picture

delzhand CreditAttribution: delzhand commented
Status: Needs work » Needs review
FileSize
move_front_page_error-1201580-20.patch15.96 KB

Updated with changes to tests.

delzhand’s picture

delzhand CreditAttribution: delzhand commented
FileSize
move_front_page_error-1201580-21.patch16.02 KB

Ran the tests locally before testbot got around to it and found another failure point.

The last submitted patch, 20: move_front_page_error-1201580-20.patch, failed testing.

delzhand’s picture

delzhand CreditAttribution: delzhand commented

21: move_front_page_error-1201580-21.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 21: move_front_page_error-1201580-21.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Component: base system » system.module

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.