I was blocked today because I didn't realise ereg doesn't use regex pattern delimiters. I think we should add a little bit of doxygen to explain that the 6.x version of file_scan_directory used ereg, rather than preg.

CommentFileSizeAuthor
#7 ereg-pcre-1199516-3.patch899 bytespsynaptic
#6 ereg-pcre-1199516-2.patch930 bytespsynaptic
#1 ereg-pcre-1199516-1.patch930 bytespsynaptic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented
Status: Active » Needs review
FileSize
ereg-pcre-1199516-1.patch930 bytes

Here's the patch.

manarth’s picture

manarth CreditAttribution: manarth commented
Status: Needs review » Reviewed & tested by the community

Useful patch - ereg is very different to preg_match, and in my experience devs expect PCRE rather than posix regex, so ereg is unexpected, and the docs should reflect this.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Needs work

Sounds a bit too informal to me. I understand it is to the point, but it clearly assumes a certain view with the "Posix not PCRE" explanation. Would be great to make it a more general explanation on what is this.

grendzy’s picture

grendzy CreditAttribution: grendzy commented
Status: Needs work » Closed (won't fix)

ereg really needs to be removed, anyway:
#883038: PHP warning: Function ereg() is deprecated in includes/file.inc

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Closed (won't fix) » Needs work

@grendzy: How would you imagine that while keeping backwards compatibility? Unless we have a plan for that, let's fix the docs instead (reopening for that).

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented
Status: Needs work » Needs review
FileSize
ereg-pcre-1199516-2.patch930 bytes

Let's try again...

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented
FileSize
ereg-pcre-1199516-3.patch899 bytes

Wrong file in last post. Here's the correct one.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.