Support for Devel Generate in deprecated mediafield

Attached is Ravi's work in patch form (no modifications made).

Attached is a different version of the patch. It does not try to generate files for usage so it is assumed that files will already be available to be referenced. Admittedly EntityFieldQuery() is new to me so some of query code is borrowed from elsewhere in Media. This certainly needs a good review and testing in a variety of circumstances. Caching of the allowed values would be helpful for speed. It could also be worth while to look at optionally generating files for reference. Finally note that this patch is against the last beta. It should be simple to adapt to dev however.

#3: 1198820-media-devel-generate2.patch queued for re-testing.

#6 1198820-media-devel-generate3.patch worked fine for me

great work on this! the only problem i see is with the non-standard hook you're implementing. firstly, if someone decides to create a media_image module, this would conflict with that module, not only disallowing its own version of the hook, but actually unintentionally calling the function twice. additionally, at some point down the road, media will most likely allow for module or user-defined media types. which will cause similar problems, for instance, with youtube or flickr.

i would suggest we create a new hook in the standard drupal way, such as hook_media_devel_generate.

changing version

Patch #6 works fine, but when I generate content during install process i get strange errors:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '' for key 'uri': INSERT INTO {file_managed} (filesize, status, timestamp, type) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3); Array
(
    [:db_insert_placeholder_0] => 0
    [:db_insert_placeholder_1] => 1
    [:db_insert_placeholder_2] => 1311840567
    [:db_insert_placeholder_3] => default
)

I did a bit of debugging and it looks like $file gets a really strange value after file_move() at line 65:

stdClass Object
(
    [is_new] => 1
    [name] => 
    [status] => 1
)

Temporary object $source looks fine though:

stdClass Object
(
    [uri] => temporary://imagefield_afYOyq.png
    [uid] => 1
    [filemime] => image/png
)

Any idea?

It's been a while on this, wondering if a fix has been committed or if this is still a hanging issue.

Tried this a patch to devel_generate here http://drupal.org/node/1589056#comment-6013772 and it didn't seem to take care of it, at least for media 2.x-dev.

Any news on this front? Should I try this patch as well? Does this technically fall within the perview of media folks or devel folks?

I have rewritten the patch due to the fact that for this to work, it nowdays need to be put in the mediafield directory and be renamed. In devel_generate it tries to include this file under the module name "mediafield" and "media"... doesnt work then.

I have extended the module to work with any source of images, for example the Lorempixel service.

/ bobodrone

Minor typo. New try.

And redo for test.

Doesn't work with default image provider nor does it work with devel_image_provider and lorempixum or flickrholdr submodules. I am testing it against the latest media 2.x-dev

can't get it to work with lorempixel module either. no errors or debug output. i will try on a simpler sandbox here in a sec.

meu error, it works on a clean install with your lorempixel module! awesome. i like your lorempoxel module better :)

Funny, without the lorempixel module I keep getting this error:

Fatal error: Call to undefined function _lorempixel_devel_generate_image() in [...]/modules/media/modules/mediafield/mediafield.devel_generate.inc on line 33

This is after disabling, uninstalling and even removing the codebase. However, I cannot find this function or any reference to lorempixel in the file at all.

Very strange! After I did a full reinstall on mediafield, I was able to swap out and use this with the default devel image provider, as well as both the devel_image_provider and lorempixel modules. I will see if I can reproduce the error above, but it seems like everything should be ok!

After subjecting it to a battery of tests, I would say that this patch works.

Hi, the trick behind this is to let devel generate to use a variable (Instead of hook function for now) to decide which of the callbacks are going to be used for image creation.

In mediafield.devel_generate there is a variable_get('devel_generate_media_file_function') in which my module Lorempixel MIGHT have stored its own callback function. If not it should use the default mediafield callback function for generating images.

It works for me but if you have this problem again, just report it and we will see what it can be. It has probably something to do with either that after you applied the patch you MUST clear the cache, or that the variable above is not set yet. To verify this, uncheck the chechbox in lorempixel and save and recheck it again and save.

b.r
/ bobodrone

Indeed, clearing the cache was the issue. This is a really innovative approach to the problem. Really love the work, thanks! (apologies for the torrent of comments...)

#15: 1198820-mediafield-devel-generate4.patch queued for re-testing.

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+<?php
+define('MEDIA_DEVEL_GENERATE_IMAGE_MAX', 5);
+/**
+ * Implements hook_devel_generate

Please add some space between lines here.
Also a @file doc block

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+      $function = "mediafield_" .$type ."_devel_generate";

Use spaces next to dots.
eg . instead of ..
Also whats the point on using double quotes here if you just concatenate the variable. Use single ones instead

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+        return $function($object, $field, $instance, $bundle, $settings);

Why return here? This stops the foreach, which leads to only one function called. The first found.

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+ * Implements media_<type>_devel_generate

Implements media_TYPE_devel_generate().

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+  // To let other modules generate media/image files instead of the standard file function.

I guess "To" is not needed here. Just "Let"

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+ * @return <type>

Fix or remove. return is boolean

+++ b/modules/mediafield/mediafield.devel_generate.incundefined
@@ -0,0 +1,133 @@
+    else {
+      return FALSE;
+    }

This is not needed

TLDR: Skip this comment... ;o)

Sorry but the coding in this is way beyond me, it's a nice to have thing and so I'm hoping to get the attention of those working on it...

So, Bump... Cheers!

I'm chasing my tail on this one. I've chased devel_generate all the way to the end on the patch in this thread only to discover that because I'm using the File field (not mediafield) this method will never fire.

Surely as mediafield is deprecated this effort should be abandoned? Please let me know if I'm wrong. It seems to me that we should pursue this thread instead http://drupal.org/node/1589056 (that one references this one).

Mediafile deprecated here
http://drupal.org/node/1324316
and here
http://drupal.org/node/1349058

Effort to hook in to file.devel_generate here
http://drupal.org/node/1589056
and here
http://drupal.org/project/devel_image_provider

This could be of intrest to read, for us to get to the goal with this issue.
https://drupal.org/node/2011776

changing title because this patch is only concerned with the deprecated mediafield and not file fields with media widget.

As mention above. Mediafile is deprecated so I think it is OK to close this.