Allow multiple setting keys per mail module. [#1197704]

Hi there,

After adding in a setting for a module (and optional key) on the settings page, the module is no longer present in the 'New Setting' module select box. This means that it is not possible to have:

- different settings for different keys in the same module
- a setting for the module and then a different setting for a specific key

The description at the top about search order seems to imply that the module looks for these in a theme-like way, looking for a module-key class, then a module class and then the site-wide default. I'm just wondering how this is possible in the current situation, as it doesn't seem that you can add in a module class and then go on to add a module-key class (or vice versa).

Is there a way to do this through the admin interface?

Thanks.

Comment	File	Size	Author
#2	mailsystem-multiple_keys_per_module_7.x-1197704-2.patch	470 bytes	damien_vancouver
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pillarsdotnet CreditAttribution: pillarsdotnet commented 23 June 2011 at 13:37

Assigned:	Unassigned	» pillarsdotnet
Status:	Active	» Needs work

Thanks for the report; I'm checking up on this.

Comment #2

damien_vancouver CreditAttribution: damien_vancouver commented 8 April 2012 at 01:12

Version:	6.x-2.26	» 7.x-2.x-dev
Status:	Needs work	» Needs review

File	Size
mailsystem-multiple_keys_per_module_7.x-1197704-2.patch	470 bytes

I had this problem too, but it was easily solved by removing line 80 of mailsystem.admin.inc (for 7.x-2.33):

 unset($descriptions[$module]);

Then the module appears in the list of available modules to create a new key for. I've now created three different keys for my module and Mail System correctly creates and registers the MailSystemInterface class for all three. I set one to HTML and one to Default and verified that I got the correct output.

Attached patch for 7.x-2.x-dev... I assume the fix would be the same for 8.x and 6.x... I could reroll for these if you want.

Comment #3

pillarsdotnet CreditAttribution: pillarsdotnet commented 10 April 2012 at 17:39

Title:	Can't create multiple settings for a module	» Allow multiple setting keys per mail module.
Status:	Needs review	» Reviewed & tested by the community

Applied patch. Will be available in next release.