Subform in field widget [#1194576]

Hello,
i want to provide possibility to edit another node in field widget. But how to submit node which form is included (by fubform element) in field widget and give back to widget the NID of saved node (for create relation to new node)?

Example of my code, which properly load subform but preview and save doesn't work:

/**
 * Implements of hook_field_widget_form().
 */
function relation_edit_field_widget_form(&$form, &$form_state, $field, $instance, $langcode, $items, $delta, $element) {
  $widget = $instance['widget'];
  $settings = $widget['settings'];
  
  if(isset($items[$delta]))
    $related_node = node_load($items[$delta]);
  else {
    global $user;
    $related_node = (object) array('uid' => $user->uid, 'name' => (isset($user->name) ? $user->name : ''), 'type' => $settings['bundle']);
  }
  
  $element['node_' . $delta] = array(
    '#type' => 'subform',
    '#subform_id' => 'node_form',
    '#subform_file' => array('module' => 'node', 'name' => 'node.pages'),
    '#subform_arguments' => array($related_node, $settings),
    '#subform_default_triggering_element' => array('actions' => 'submit'),
    '#required' => FALSE,
  );
  
  //dpm($element);
  return $element;
}

Comments

Comment #1

casey CreditAttribution: casey commented 21 June 2011 at 18:44

Cool use case! Don't you have a git sandbox or something, so I can check it out/see how to fix it?

Comment #2

Honza Pobořil CreditAttribution: Honza Pobořil commented 21 June 2011 at 20:55

It will be there in a few minutes: http://drupal.org/sandbox/bobik/1195712

Comment #4

casey CreditAttribution: casey commented 22 June 2011 at 14:17

I am sorry but the whole relation dummy field doesn't seem to be usable to create/save relations. Relations aren't stored in the field data so you can't retrieve them and their target entities per field index.

So this is entirely incorrect (but there isn't really a correct way to do it):

    $related_node = node_load($items[$delta]); // $items[$delta] contains nothing

I think the dummy field is only created to display relations as a field so you can use different formatters.

Anyways, to get the subforms submitting while pressing the save button on the parent form you can:

  $element['node_' . $delta] = array(
    '#type' => 'subform',
    '#subform_id' => 'node_form',
    '#subform_file' => array('module' => 'node', 'name' => 'node.pages'),
    '#subform_arguments' => array($related_node, $settings),
    '#subform_default_triggering_element' => array('actions' => 'submit'),
    '#required' => FALSE,
  );

  // Add one submit handler to the form that handles all subforms.
  $form_state['complete form']['#submit'][] = 'subform_submit_all';

Comment #5

Honza Pobořil CreditAttribution: Honza Pobořil commented 22 June 2011 at 18:00

I am using patched version of relation_dummy_field and there is loaded related NIDs, but it seems that is not propper way. I am going to update my module to work with master version of relation_dummy field.

Comment #6

Honza Pobořil CreditAttribution: Honza Pobořil commented 22 June 2011 at 22:02

Try the newest version. Now it loads relations and multiple values is handled in one widget, so clear cache, please.

Comment #7

casey CreditAttribution: casey commented 22 June 2011 at 23:02

Ow wait,

$form_state['complete form']['#submit'][] = 'subform_submit_all';

should be

$form_state['complete form']['#submit']['subform_submit_all'] = 'subform_submit_all';

Else it would add the submit handler multiple times if your form contains multiple subforms.

Comment #8

Honza Pobořil CreditAttribution: Honza Pobořil commented 22 June 2011 at 23:06

or $form variable?

$form['complete form']['#submit']['subform_submit_all'] = 'subform_submit_all';

Comment #9

casey CreditAttribution: casey commented 22 June 2011 at 23:10

$form argument in hook_widget_form() is not necessarily the actual $form element.

Comment #10

Honza Pobořil CreditAttribution: Honza Pobořil commented 22 June 2011 at 23:14

I've updated this, but it still doesn't work. (checkout last commit)

Comment #11

casey CreditAttribution: casey commented 23 June 2011 at 00:04

Oww of course, hook_widget form is called before form_builder() is run. There is no complete form yet.

Add this to relation_edit_field_widget_form():

  $widget = $instance['widget'];
  $settings = $widget['settings'];

  $element['#process'][] = 'relation_edit_field_widget_form_process';

And this extra function:

function relation_edit_field_widget_form_process($element, &$form_state, &$form) {
  // Add one submit handler to the form that handles all subforms.
  $form['#submit']['subform_submit_all'] = 'subform_submit_all';

  return $element;
}

Comment #12

Honza Pobořil CreditAttribution: Honza Pobořil commented 23 June 2011 at 01:22

No, it still does not work (related nodes were not updated).

Comment #13

casey CreditAttribution: casey commented 23 June 2011 at 01:53

Well thats because you hide all submit buttons on the subform. If you expose those, it works.

But I see why you need to be able to have subforms without submit buttons, so I'll work out a solution.

Comment #14

casey CreditAttribution: casey commented 23 June 2011 at 01:59

Actually it is possible. You had '#subform_default_triggering_element' wrong

 '#subform_default_triggering_element' => array('actions' => 'submit'),

should be

 '#subform_default_triggering_element' => array('actions', 'submit'),

Comment #15

Honza Pobořil CreditAttribution: Honza Pobořil commented 23 June 2011 at 02:38

Repaired, but still doesn't work. Btw, you have the same mistake in subform_example.module on the line 289.

Comment #16

casey CreditAttribution: casey commented 23 June 2011 at 02:50

Have you updated to latest subform version?

Comment #17

Honza Pobořil CreditAttribution: Honza Pobořil commented 23 June 2011 at 05:17

Yes, after update Subform it is working now. Thank you.

How do you recommend to implement creating new nodes? I have prepared creating new nodes, but I don't know how to get back NID of new node to create relation.

Comment #18

casey CreditAttribution: casey commented 23 June 2011 at 17:44

To save you some troubles when debugging, note that sessions have a storage limit. if you dsm($form_state), and the form is submitted and redirected (which means that $_SESSION['messages'] is going to be stored), you'll likely don't see any status messages at all. $form_state is way too large to be stored in session storage.

I ran into this while getting this to work.