Hi,

What is the exact purpose of the function commerce_addressbook_build_form_id_list(), other than attaching the commerce_addressbook.js file to the form?
The variable $fieldnames is a string on line 56, and threated as an array below, so I suppose this code is obsolete? The Drupal.settings.addressfield_names is not used in the Javascript file anyway...

If this is true, can we clean up this function and perhaps give it a more descriptive name? This will make it easier to understand what's going on in the module :)

Comments

megensel’s picture

Remnants of a failed try at grabbing the id's of the fields that need to get updated. went with a different approach, I will clean it up with my next commit.

j0rd’s picture

In the version I have on my laptop right now, this is also removed.

This module is going to need to get re-done from scratch imho.

megensel’s picture

Status: Active » Fixed

removed on my latest commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.