Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
What is the exact purpose of the function commerce_addressbook_build_form_id_list(), other than attaching the commerce_addressbook.js file to the form?
The variable $fieldnames is a string on line 56, and threated as an array below, so I suppose this code is obsolete? The Drupal.settings.addressfield_names is not used in the Javascript file anyway...
If this is true, can we clean up this function and perhaps give it a more descriptive name? This will make it easier to understand what's going on in the module :)
Comments
Comment #1
megensel CreditAttribution: megensel commentedRemnants of a failed try at grabbing the id's of the fields that need to get updated. went with a different approach, I will clean it up with my next commit.
Comment #2
j0rd CreditAttribution: j0rd commentedIn the version I have on my laptop right now, this is also removed.
This module is going to need to get re-done from scratch imho.
Comment #3
megensel CreditAttribution: megensel commentedremoved on my latest commit.