I've got a blogspot feed that I'm pulling in and the feed is set to use the "short" configuration (cut off at 400 characters). For some reason this changes the feed so that the description is showing up as "atom:summary" instead of "description" or "summary." This caused all of the descriptions for this feed to disappear. Adding a quick case for that element seemed to fix the problem.
I wasted some time tracking this down so I thought I'd post. Minor issue, Not sure if this is something dumb that blogspot is doing or if this is happening in the parsing (I didn't actually see the key for that element with the "atom:" prefix when I looked at the raw feed). A very rough patch attached (made against my svn so might fail testing). Needs review.
Comment | File | Size | Author |
---|---|---|---|
#9 | aggregator_atom_summary_1190962_02.patch | 619 bytes | kathyh |
#2 | aggregator_atom_summary_1190962_02.patch | 599 bytes | seanbfuller |
aggregator_atom_summary.patch | 487 bytes | seanbfuller |
Comments
Comment #2
seanbfuller CreditAttribution: seanbfuller commentedUpdated patch against 7.x in git. The questions about this even being the right method still apply.
Comment #4
seanbfuller CreditAttribution: seanbfuller commented#2: aggregator_atom_summary_1190962_02.patch queued for re-testing.
Comment #5
twistor CreditAttribution: twistor commentedCould you supply a feed that illustrates the problem? The question is whether this is a parsing problem or just a lack of a supported element. Also, it will help with tests.
Comment #6
seanbfuller CreditAttribution: seanbfuller commentedHere's the feed in question: http://iamlogansquare.blogspot.com/feeds/posts/default?alt=rss and here's the non-rss version, just in case: http://iamlogansquare.blogspot.com/feeds/posts/default
Thanks
Comment #7
twistor CreditAttribution: twistor commentedOk, so this seems to be odd. It appears that what they are doing is valid as per http://tools.ietf.org/html/rfc4287#section-4.2.13. The problem is actually a lack of namespace support in our parser. For whatever reason they are declaring the atom namespace in their RSS feed.
In reality we should support namespaces properly in our parser. That would involve a major overhaul. Hopefully at the same time we could get rid of the global variables, $items, $image, $channel. Or just use simplepie. But that's for another issue.
I think this is a valid feature request, either way, as blogger is a major producer of feeds. I also think it's valid for backporting.
Patch applies cleanly to 8.x
Comment #8
chx CreditAttribution: chx commentedComment #9
kathyh CreditAttribution: kathyh commentedAttached is updated patch per 8.x /core dir pathname change. Verified given blogspot feed does show up, however, per #7, verify scope of this issue.
Comment #10
thedavidmeister CreditAttribution: thedavidmeister commentedpatch no longer applies.
error: core/modules/aggregator/aggregator.parser.inc: No such file or directory
this issue is tagged with "Needs tests" and there are no tests in #9.
Comment #21
SpokjeThe
aggregator
module has been removed from Core in10.0.x-dev
and now lives on as a contrib module.Issues in the Core queue about the
aggregator
module, like this one, have been moved to the contrib module queue.Comment #22
larowlanIs this still an issue?
Tagging needs reroll for contrib
Comment #23
dcam CreditAttribution: dcam as a volunteer commentedNo, it's no longer an issue. The Laminas feed reader supports Atom feeds. The feed mentioned in #6 is still available. All of its item summaries were imported with no problem.
If anyone is still experiencing an issue with the contrib version of Aggregator, then please feel free to re-open the issue.