I've got a blogspot feed that I'm pulling in and the feed is set to use the "short" configuration (cut off at 400 characters). For some reason this changes the feed so that the description is showing up as "atom:summary" instead of "description" or "summary." This caused all of the descriptions for this feed to disappear. Adding a quick case for that element seemed to fix the problem.

I wasted some time tracking this down so I thought I'd post. Minor issue, Not sure if this is something dumb that blogspot is doing or if this is happening in the parsing (I didn't actually see the key for that element with the "atom:" prefix when I looked at the raw feed). A very rough patch attached (made against my svn so might fail testing). Needs review.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, aggregator_atom_summary.patch, failed testing.

seanbfuller’s picture

Status: Needs work » Needs review
FileSize
599 bytes

Updated patch against 7.x in git. The questions about this even being the right method still apply.

Status: Needs review » Needs work

The last submitted patch, aggregator_atom_summary_1190962_02.patch, failed testing.

seanbfuller’s picture

Status: Needs work » Needs review
twistor’s picture

Status: Needs review » Postponed (maintainer needs more info)

Could you supply a feed that illustrates the problem? The question is whether this is a parsing problem or just a lack of a supported element. Also, it will help with tests.

seanbfuller’s picture

Status: Postponed (maintainer needs more info) » Active

Here's the feed in question: http://iamlogansquare.blogspot.com/feeds/posts/default?alt=rss and here's the non-rss version, just in case: http://iamlogansquare.blogspot.com/feeds/posts/default

Thanks

twistor’s picture

Version: 7.x-dev » 8.x-dev
Category: support » feature
Status: Active » Reviewed & tested by the community

Ok, so this seems to be odd. It appears that what they are doing is valid as per http://tools.ietf.org/html/rfc4287#section-4.2.13. The problem is actually a lack of namespace support in our parser. For whatever reason they are declaring the atom namespace in their RSS feed.

In reality we should support namespaces properly in our parser. That would involve a major overhaul. Hopefully at the same time we could get rid of the global variables, $items, $image, $channel. Or just use simplepie. But that's for another issue.

I think this is a valid feature request, either way, as blogger is a major producer of feeds. I also think it's valid for backporting.

Patch applies cleanly to 8.x

chx’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests
kathyh’s picture

Status: Needs work » Needs review
FileSize
619 bytes

Attached is updated patch per 8.x /core dir pathname change. Verified given blogspot feed does show up, however, per #7, verify scope of this issue.

thedavidmeister’s picture

Status: Needs review » Needs work

patch no longer applies.

error: core/modules/aggregator/aggregator.parser.inc: No such file or directory

this issue is tagged with "Needs tests" and there are no tests in #9.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
Spokje’s picture

Project: Drupal core » Aggregator
Version: 9.3.x-dev » 1.x-dev
Component: aggregator.module » Code
Issue summary: View changes

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module.
Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

larowlan’s picture

Version: 1.x-dev » 2.x-dev
Issue tags: +Needs reroll

Is this still an issue?

Tagging needs reroll for contrib

dcam’s picture

Status: Needs work » Closed (outdated)

No, it's no longer an issue. The Laminas feed reader supports Atom feeds. The feed mentioned in #6 is still available. All of its item summaries were imported with no problem.

If anyone is still experiencing an issue with the contrib version of Aggregator, then please feel free to re-open the issue.