Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We could argue a profile is an article, especially so if/when profiles become proper entities (http://groups.drupal.org/node/155634 some related discussion).
http://api.drupal.org/api/drupal/modules--user--user-profile.tpl.php
Comment | File | Size | Author |
---|---|---|---|
#11 | 1190214-11.patch | 1.33 KB | aspilicious |
#7 | user-profile-html5-1190214-7.patch | 1.16 KB | stijnbe |
#4 | user-profile-html5-1190214-4.patch | 490 bytes | stijnbe |
#1 | user-profile.tpl_.php-html5-1190214.patch | 429 bytes | stijnbe |
Comments
Comment #1
stijnbe CreditAttribution: stijnbe commentedI changed the div tags into html5 article tags. Patch attached.
Comment #2
stijnbe CreditAttribution: stijnbe commentedComment #4
stijnbe CreditAttribution: stijnbe commentedI added foaf:person xmlns:foaf="http://xmlns.com/foaf/0.1/". Is this the right way to add rdfa for a user profile?
Comment #5
stijnbe CreditAttribution: stijnbe commentedIt seems like I was a bit to fast. The correct rdfa tag was already set with the patch in comment #1. Why is the test failing?
Comment #7
stijnbe CreditAttribution: stijnbe commentedfixed rdf.test
Comment #8
scor CreditAttribution: scor commented@stijnbe: re #4, as you found out, no need to add the namespaces manually, they are handled automatically by Drupal (and inserted in the html tag at the top of the HTML output).
Comment #9
cosmicdreams CreditAttribution: cosmicdreams commentedAs per http://www.drupal4hu.com/node/304 , Profile is no longer apart of D8. Can we (won't fix) this issue?
Comment #10
droplet CreditAttribution: droplet commentedOh. Profile module still in D7 and hidden, never known it.
the file in this issue used by User module :)
Comment #11
aspilicious CreditAttribution: aspilicious commentedThis looks very RTBC for me...
Rerolled.
Adding sprint tag so it gets noticed this sunday. (if there is a sprint on sunday)
Comment #12
aspilicious CreditAttribution: aspilicious commentednot rtbc yet ;)
Comment #13
aspilicious CreditAttribution: aspilicious commentedforgot the tag :(
Comment #14
JacineThis is RTBC. Shouldn't have the sprint tag though. We define issues for the sprints every other Tuesday in our IRC meeting.
Comment #15
catchhmm it feels like a stretch calling user account pages as core provides them an article. Out of the box it is just "Member for x weeks and y days" and not a lot else. On Drupal.org it includes all the stuff at http://drupal.org/user/35733 including commits etc. within what is currently that div.
I'm not going to argue against it, but it'd be good to have a better justification for why this is semantically a good idea.
Comment #16
mortendk CreditAttribution: mortendk commentedusing the article tag here is 100% what its used for, its very specific, out of the box every little tiny node in drupal is probably article, its nothing to do with the size of it.
to quote from the good htnl5 doctor
http://html5doctor.com/the-article-element/
or take it from our good friends at MDN
https://developer.mozilla.org/en/HTML/Element/article
not using article here would be a great mistake & its following the precise definition of the tag.
rtbc +1
Comment #17
catchOK the html5doctor example is not really conclusive for me does "member for 5 weeks" make sense out of context?
However ", an interactive widget or gadget, or any other independent item of content." sounds completely OK for this, and it's not the template's fault that the account page is a bit bare out of the box.
Committed and pushed to 8.x, thanks!