hook_theme has error in the 'function' section of return value [#1190110]

API page: http://api.drupal.org/api/drupal/developer--hooks--core.php/function/hoo...

Describe the problem you have found:

> function: If specified, this will be the function name to invoke for this implementation. If neither file nor function is specified, a default function name will be assumed. For example, if a module registers the 'node' theme hook, 'theme_node' will be assigned to its function. If the chameleon theme registers the node hook, it will be assigned 'chameleon_node' as its function.

I *think* that should say 'neither template nor function'.

Comment	File	Size	Author
#14	doc-hook-theme-D6.patch	6.77 KB	sven.lauer
#8	hook_theme_doc-1190110-8.patch	4.48 KB	oriol_e9g
#3	hook_theme_doc-1190110-4.patch	817 bytes	oriol_e9g

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 16 June 2011 at 23:03

Issue tags:

+Novice, +Needs backport to D7

I agree that you are correct, it should say "If neither template nor function is specified, ...". Good project for a novice doc contributor!

Comment #2

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 16 June 2011 at 23:04

Title:

Documentation problem with hook_theme

» hook_theme has error in the 'function' section of return value

And it's a problem in D6/7/8

Comment #3

oriol_e9g

Catalan

Barcelona

CreditAttribution: oriol_e9g commented 17 June 2011 at 18:23

Status:

Active

» Needs review

File	Size
hook_theme_doc-1190110-4.patch	817 bytes

Try with this.

Comment #4

17 June 2011 at 18:26

Status:	Needs review	» Needs work
Issue tags:	-Needs backport to D6, -Novice, -Needs backport to D7

The last submitted patch, hook_theme_doc-1190110-4.patch, failed testing.

Comment #5

oriol_e9g

Catalan

Barcelona

CreditAttribution: oriol_e9g commented 17 June 2011 at 18:31

Status:	Needs work	» Needs review
Issue tags:		+Needs backport to D6, +Novice, +Needs backport to D7

#3: hook_theme_doc-1190110-4.patch queued for re-testing.

Comment #6

joachim CreditAttribution: joachim commented 17 June 2011 at 19:13

Looks good to me.

Though I notice that the key names should be in quotes, like 'path' above.
But that could be left to another issue -- maintainer's call :)

Comment #7

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 17 June 2011 at 20:33

Status:

Needs review

» Needs work

I agree with Joachim - it would be nice to put 'template' and 'file' in quotes.

Comment #8

oriol_e9g

Catalan

Barcelona

CreditAttribution: oriol_e9g commented 20 June 2011 at 11:24

File	Size
hook_theme_doc-1190110-8.patch	4.48 KB

Key names in quotes and comments wrapped to 80 chars

Comment #9

oriol_e9g

Catalan

Barcelona

CreditAttribution: oriol_e9g commented 20 June 2011 at 12:38

Status:

Needs work

» Needs review

Comment #10

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 20 June 2011 at 15:48

Status:

Needs review

» Reviewed & tested by the community

Looks good to me, for 7.x/8.x please. Thanks!

Comment #11

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 5 July 2011 at 04:56

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed to 8.x and 7.x. Thanks!

Comment #12

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 5 July 2011 at 04:57

Version:	8.x-dev	» 6.x-dev
Status:	Fixed	» Patch (to be ported)
Issue tags:	-Needs backport to D7

Oops. I guess this needs backport to D6 too.

Comment #13

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 20 September 2011 at 15:50

Project:	Drupal core	» Documentation
Version:	6.x-dev	»
Component:	documentation	» API documentation files

Oh and for d6 it's in the docs project

Comment #14

sven.lauer CreditAttribution: sven.lauer commented 13 November 2011 at 02:35

Status:

Patch (to be ported)

» Needs review

File	Size
doc-hook-theme-D6.patch	6.77 KB

Re-rolling for D6. There also were a number of wrapping issues in hook_theme's doc, which I took care of with this patch as well (+slight rewording in the intro paragraph: "info"->"information").