subj

CommentFileSizeAuthor
#1 1189686-transliteration.patch526 bytesrbayliss
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rbayliss’s picture

rbayliss CreditAttribution: rbayliss commented
Status: Active » Needs review
FileSize
1189686-transliteration.patch526 bytes

Let me know how this looks.

Karol Haltenberger’s picture

Karol Haltenberger CreditAttribution: Karol Haltenberger commented

It looks good, but 'commerce_autosku_cleanstring' should be run before converting the case, otherwise transliteration's case settings overrule autosku's settings.
Unless there is a reason behind the current order of things.

commerce_autosku.commerce.inc lines 70-80

      $sku = commerce_autosku_cleanstring($sku); //
      if ($settings['advanced']['case']) {
        switch ($settings['advanced']['case']) {
...
rbayliss’s picture

rbayliss CreditAttribution: rbayliss commented
Status: Needs review » Fixed

Thanks for the review. I can't see any reason to run the cleanstring function later. Fixed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.