Hi,

is there a way to delegate meta tags appliance conditions to the proper Context module and then concentrate on the meta tags reaction?

Context is a great module which phylosophy is very user friendly, and having all reactions in one place allows to save time.

Files: 
CommentFileSizeAuthor
#23 metatag-n1187710-23.patch923 bytesDamienMcKenna

Comments

Dave Reid’s picture

Status:Active» Postponed (maintainer needs more info)

I'm not too familiar with the context module so it may take someone else to write this code. Leaving as postponed for now.

dropbydrop’s picture

sub

Dave Reid’s picture

Status:Postponed (maintainer needs more info)» Postponed

I did not use the correct postponed.

DamienMcKenna’s picture

Version:» 7.x-1.x-dev

Two related modules:

I think this should be done as a submodule so it can leverage & standardize on the main module's meta tagging, e.g. #1160340: Rewrite as a submodule of Metatags (D7 branch), possibly inviting other authors to join as co-maintainers for their pieces. Thoughts?

DamienMcKenna’s picture

Title:Integrated as a Context reaction» Integrate with Context

Updated title.

dakku’s picture

HI Damien,
You have mail :D

tahiticlic’s picture

Nice Damien!

dropbydrop’s picture

So since there is new module, is this issue fixed?

DamienMcKenna’s picture

@dropbydrop: I'd like Metatag have the ability to do this out of the box.

DamienMcKenna’s picture

Digging into it I think this needs to be a submodule, but I also think it should be the official mechanism for assigning meta tags to content by path rather than by entity.

DamienMcKenna’s picture

Drawing a blank. I need to talk with Dave about how to combine the context-driven meta tags with the ones generated by the system. Argh.

DamienMcKenna’s picture

Status:Postponed» Active

FYI I've uploaded some WIP code to the 'context' branch.

Marcin Pajdzik’s picture

My integration code can be checked out from here: http://drupal.org/sandbox/marcin_pajdzik/1810914

DamienMcKenna’s picture

Marcin Pajdzik++
:)

DamienMcKenna’s picture

I've tested out the new sandbox and, well, it's *great*! *Really* good work, Marcin!

blairski’s picture

I did a test run and it works well. Good job .

Just one thing: change the module name to

Meta Context.

. Currently the git clone creates

context_and_metatag_integration
Marcin Pajdzik’s picture

Thanks for the reviews guys. I have slightly changed the way the metatag "per path" admin page works as the previous solution was unreliable:
#1814074: Improve the level of control over what is being displayed on the metatag per path admin page.

DamienMcKenna’s picture

Status:Active» Needs review

I've merged in Marcin's sandbox into the new 1187710-context branch. I've made a few small changes, inc renaming the admin page's path, but the kudos go to Marcin.

DamienMcKenna’s picture

DamienMcKenna’s picture

I've made a number of improvements to the Context submodule:

  • The custom by-path edit form will indicate if other conditions have been added to the context.
  • When editing the settings via the main Context UI module, automatically collapse the Open Graph and (forthcoming) Dublin Core fieldsets, in addition to the Advanced fieldset which is already collapsed; the title, description and a dividing line are added to improve the UX.
  • All defaults have been removed, instead the global defaults will automatically be used.
  • A few small typos have been fixed, along with some coding standards glitches.
  • Some additional inline help messages have been added.
  • Improved the README.txt file.

This appears to be working fine.

Marcin Pajdzik’s picture

One more fix. Please change:

$contexts = context_enabled_contexts();

to:

$contexts = context_enabled_contexts(TRUE);

in metatag_context.admin.inc line 11

DamienMcKenna’s picture

Status:Needs review» Fixed

Committed! Thanks everyone for your help with this, especially Marcin!

DamienMcKenna’s picture

StatusFileSize
new923 bytes

A little follow-up to update the main module's README.txt file.

DamienMcKenna’s picture

I've committed the patch from #23 too.

DamienMcKenna’s picture

Status:Fixed» Closed (fixed)

Last night saw the release of 7.x-1.0-beta1, so I'm closing all these "fixed" issues in the interest of tidying up the issue queue. Thank you all for your help getting us to this point!

remkovdz’s picture

This works great, thanks a lot!

MXT’s picture

Only to inform you guys: I've installed latest DEV version of context (2012-Oct-10) and no metatada reaction is available in context UI.

Downgrading to context 7.x-3.0-beta4 meradata reaction return available.

DamienMcKenna’s picture

@MXT: Please open a new issue for this. Thanks.

mstrelan’s picture

@MXT - see #1871798: Context reaction is not available after module installation until the cache is cleared. This might result in an additional issue for metatag.