The Editable Modal Widget looks and works great to allow non advanced users to update certain content.

One thing I have had over the past two weeks, at some seemingly random point in time, any field set to Editable Modal Widget disappears. I am using them in Panels and Views. When I check the Panel or View configuration, the option to set Editable Modal Widget is also simply gone. The other options such as Click to Edit remain.

The last couple times this has happened, I have found that "Flush All Caches" resolves the problem and the fields reappear.

I previously thought this might be a conflict with the Advanced Aggregation module which I use to cache CSS and JS, but this time flush the Advanced Agg cache did not resolve the problem.

I have now disabled Page Cache - Caching mode under Performance to see if that helps. I really like the Modal widget and would like to keep it. It becomes complicated when the field disappears, and the randomness of it causes me to check throughout the day.

In any case thanks for the module and the widget, they are both very helpful. I have little understanding how caching works or Editablefields could be effected but if there is anything I can do to help debug I will be happy to do it.

Comments

itserich’s picture

itserich CreditAttribution: itserich commented

Want to note, the issue with the Modal Widget is with the prior development release (the current version did not work for me with greater errors).

I have figured out running Drupal Flush All Caches reinstates the widget.

This is the only field type which is working for me, and I don't understand what is happening with cache to cause the problem. If there is a way to automate the clearing of the responsible cache or stopping the cache from working I would appreciate the information. Thank you.

andreiashu’s picture

andreiashu CreditAttribution: andreiashu commented
Title: Editablefields Modal Widget - fields disappear at some point, flushing Drupal cache "Flush All Caches" causes them to reappear » Editablefields JS code not compatible with JS Aggregation

Hi itserich,

I'll commit some code that hopefully should fix this.

Thanks,
Andrei

andreiashu’s picture

andreiashu CreditAttribution: andreiashu commented
Status: Active » Needs review

Please have a look in the latest 6.x-3.x snapshot (there should be a new one available within the next 12 hours) or just pull the latest code from GIT. I committed here a possible fix.

andreiashu’s picture

andreiashu CreditAttribution: andreiashu commented
Assigned: Unassigned » andreiashu
itserich’s picture

itserich CreditAttribution: itserich commented

Thanks Andrei.

The new version seems to be working fine for the Modal Widget. It has kept working for the past day without disappearing, though it rarely disappeared previously so it could still happen.

It is such a great interface, thank you for your efforts.

itserich’s picture

itserich CreditAttribution: itserich commented

Update -

Sorry, this worked fine in Mozilla and Firefox, but when I tried in IE 9 I was prompted to save a JS file.

So, I reverted to the pre May 31 dev version.

If this is a JS aggregation problem I did not realize IE has a problem with JS I was aware of the CSS problem with IE.

andreiashu’s picture

andreiashu CreditAttribution: andreiashu commented
Status: Needs review » Needs work

Hi itserich,

Sorry, at the moment I'm not able to test this against IE 9.

The fact that it is prompting you to download the JS file is weird... If you can provide more debugging information about it would be great.

Thanks,
Andrei

itserich’s picture

itserich CreditAttribution: itserich commented

Hi Andrei -

I would like to provide information but do not know what to do.

The version I am using now which is a couple versions ago seems to work fine, almost all the time. It has not disappeared for several days, and when it does a few cache flushes reinstates it.

I don't understand why clearing Drupal cache fixes things, I am not using Drupal's JS compression, but the Advanced Aggregation module:

http://drupal.org/project/advagg

Advanced Aggregation also includes a JS bundler.

If there are any steps I can take to help debug let me know and I will be happy to do it. Thank you.

andreiashu’s picture

andreiashu CreditAttribution: andreiashu commented
Title: Editablefields JS code not compatible with JS Aggregation » Editablefields JS code not compatible with Advanced Aggregation module

Hi itserich,

That is weird. I will have a look into it when I get some time. If the version that you are using is working for you I would like to tackle this issue at a later time as right now we are deep into the 3.x branch.

Also changed the title to better reflect the problem.

Thank you,
Andrei

itserich’s picture

itserich CreditAttribution: itserich commented

The version I have works great and with no one else reporting the issue it could be something unique.

I am not sure it is a conflict with Advanced Aggregation module. It may be, but then it is odd to me that clearing the standard Drupal cache clears the issue. Advanced Aggregation has its own cache clearing, but that is not required to fix it.

In any case, it only becomes a problem once every few days so it is not much of an incovenience. Otherwise, the modal widget looks and works great.

YesCT’s picture

YesCT CreditAttribution: YesCT commented

This might be similar to a problem I have experienced also (in some situations) with IE trying to save a file. See #1208094: Filefield AJAX editables break when more than one is included on the page

itserich’s picture

itserich CreditAttribution: itserich commented

Hi YesCT

Not sure it is the same problem. For me, at some point the option to choose any of the editable fields would simply disappear, and flushing cache, once or more, fixed it. It did not matter if there was only one or more than one editable field on a page.

And, as to Ajax, for field displays, I primarily used Modal Widget and Click to Edit. So if Ajax relates to the Ajax editable field, then that probably did not apply for my use.

In any case, I upgraded to latest dev version, and it seems to be working. I disabled Advanced Aggregation module to see if this version works. I will try Adv Agg in a week or so if this version keeps working, perhaps any conflict is gone now.

itserich’s picture

itserich CreditAttribution: itserich commented
Title: Editablefields JS code not compatible with Advanced Aggregation module » Editable Fields - disable and reenable at random times - during Drupal built in cache flushing

I am going to rename the issue to make it easier to find, pretty sure there is no conflict with Adv Agg.

Basically, flushing cache can both disable and reenable the editable fields, at least the modal widgets in the current release, and the past few releases.

This happened after I uninstalled Adv Agg. It is such a rare problem, once every 2 or 3 days, it is not much of a bother.

mengi’s picture

mengi CreditAttribution: mengi commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

Per https://drupal.org/node/2148735, 6.x is longer maintained so issue is closed. If you wish to be a maintainer of the 6.x branch please create a new issue.