hello,

thanks for this great theme!

get this error every saving (save configuration) at the theme settings for openpublic_eu:

Notice: Undefined index: favicon_path in system_theme_settings_validate() (line 637 of /mnt/weba/63/41/51582541/htdocs/mywebsite/modules/system/system.admin.inc).
Notice: Undefined index: favicon_upload in system_theme_settings_submit() (line 686 of /mnt/weba/63/41/51582541/htdocs/mywebsite/modules/system/system.admin.inc).

best regards

Files: 
CommentFileSizeAuthor
#19 core_1183708_favicon_undefined_index.patch1.72 KBLiam Morland
FAILED: [[SimpleTest]]: [MySQL] 40,691 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#16 core_1183708_favicon_undefined_index.patch1.72 KBLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 41,237 pass(es).
[ View ]
#15 core_1183708_favicon_undefined_index-screenshot_before-15.png14.31 KBmimes
#11 core_1183708_favicon_undefined_index.patch1.72 KBLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 40,409 pass(es).
[ View ]
#5 core_1183708_favicon_undefined_index_D8.patch1.83 KBLiam Morland
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core_1183708_favicon_undefined_index_D8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 core_1183708_favicon_undefined_index.patch1.72 KBLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 40,328 pass(es).
[ View ]

Comments

onair1’s picture

Component:Code» User interface
creatcat’s picture

me to

Liam Morland’s picture

Title:Error every saving in admin/appearance/settings/openpublic_eu » Notice: Undefined index: favicon_path in system_theme_settings_validate()
Project:Open Public Europe» Drupal core
Version:7.x-1.1-beta1» 7.17
Component:User interface» theme system
Status:Needs work» Active

This is a core bug. It happens when saving a theme settings page for a theme that has features[] = favicon commented out.

Full error messages:

Notice: Undefined index: favicon_path in system_theme_settings_validate() (line 649 of /var/www/drupal7/modules/system/system.admin.inc).
Notice: Undefined index: favicon_upload in system_theme_settings_submit() (line 713 of /var/www/drupal7/modules/system/system.admin.inc).

Liam Morland’s picture

Version:7.17» 7.x-dev
Component:theme system» system.module
Status:Active» Needs review
StatusFileSize
new1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 40,328 pass(es).
[ View ]

This patch fixes this for favicons and the same issue for logo uploads.

Liam Morland’s picture

Version:7.x-dev» 8.x-dev
StatusFileSize
new1.83 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core_1183708_favicon_undefined_index_D8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

D8 version.

Liam Morland’s picture

Version:8.x-dev» 7.x-dev

This code has now been completely re-written in D8, so this just needs to be fixed in D7.

Liam Morland’s picture

Liam Morland’s picture

Liam Morland’s picture

Status:Needs review» Needs work

The last submitted patch, core_1183708_favicon_undefined_index_D8.patch, failed testing.

Liam Morland’s picture

Status:Needs work» Needs review
StatusFileSize
new1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 40,409 pass(es).
[ View ]

Re-uploading the D7 patch so that it is the latest and will get tested.

This code has now been completely re-written in D8, so this just needs to be fixed in D7.

Liam Morland’s picture

Liam Morland’s picture

Liam Morland’s picture

mimes’s picture

Patch works well. I don't think there are any cases where it may cause new issues, looking at the code.

Liam Morland’s picture

StatusFileSize
new1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 41,237 pass(es).
[ View ]

Reroll.

Liam Morland’s picture

kolafson’s picture

Status:Needs review» Reviewed & tested by the community

Patch works for me, error no longer appears

Liam Morland’s picture

StatusFileSize
new1.72 KB
FAILED: [[SimpleTest]]: [MySQL] 40,691 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Reroll.

seworthi’s picture

Rerolled patch (#19) works for me, error no longer appears.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 19: core_1183708_favicon_undefined_index.patch, failed testing.

Status:Needs work» Needs review
Liam Morland’s picture

Status:Needs review» Reviewed & tested by the community

Returning status to state before faulty testbot failure.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 19: core_1183708_favicon_undefined_index.patch, failed testing.

Liam Morland’s picture

Status:Needs work» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 19: core_1183708_favicon_undefined_index.patch, failed testing.

David_Rothstein’s picture

Status:Needs work» Fixed

Committed to 7.x - thanks!

(Committed straight from "needs work" since the test failure above is bogus.)

  • David_Rothstein committed 62c952c on 7.x
    Issue #1183708 by Liam Morland | onair1: Fixed Notice: Undefined index:...
Liam Morland’s picture

Thanks very much!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.