Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Lets remove all IE6-specific CSS
Comment | File | Size | Author |
---|---|---|---|
#6 | applying the patch.PNG | 29.41 KB | cosmicdreams |
#1 | 1182870.patch | 10.95 KB | casey |
Comments
Comment #1
casey CreditAttribution: casey commentedComment #2
casey CreditAttribution: casey commentedAlso contains Javascript.
Comment #3
jrabeemer CreditAttribution: jrabeemer commentedSo I guess the proper way to test this patch is to test if IE6 breaks? LOL It sounds good to me either way. :)
Comment #4
cosmicdreams CreditAttribution: cosmicdreams commentedI'll try to test this using IETester tonight http://www.my-debugbar.com/wiki/IETester/HomePage
Comment #5
cosmicdreams CreditAttribution: cosmicdreams commentedI need to check the documentation for applying patches again. I can't seem to apply this one using git apply.
Comment #6
cosmicdreams CreditAttribution: cosmicdreams commentedHere's a screenshot of my issue. Perhaps my true issue is that I'm trying to apply this patch using git for Windows.
Comment #7
cosmicdreams CreditAttribution: cosmicdreams commentedSo... I can apply other patches using the methods I've described above but not this one. Can you reroll the patch casey?
Comment #8
seutje CreditAttribution: seutje commented@cosmicdreams: patch seems to lack prefix paths, just add -p0 to whatever ur using to apply it (ergo, "git apply -p0" || "patch -p0")
@casey: don't --no-prefix anymore, bot can handle prefixed patches and that's the standard now afaik
Comment #9
cosmicdreams CreditAttribution: cosmicdreams commentedah, ok, just like in the CVS age. (get it, like "Dark Age". )
Comment #10
cosmicdreams CreditAttribution: cosmicdreams commentedok, I got the patch to apply. I'll be able to test this out tomorrow.
I guess the test plan for this patch is to try out every page. right?
Comment #11
aspilicious CreditAttribution: aspilicious commentedI think we should split this up in smaller pieces. Larg parts of this is also done in other theme specific patches. It's easier if we split it up, will be commited faster.
Comment #12
aspilicious CreditAttribution: aspilicious commentedSrry but I'm going to close the duplicates because we are patching in 3 different places
#308865: Drop IE6 support in Drupal core