Lets remove all IE6-specific CSS

CommentFileSizeAuthor
#6 applying the patch.PNG29.41 KBcosmicdreams
#1 1182870.patch10.95 KBcasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

casey’s picture

Status: Active » Needs review
FileSize
10.95 KB
casey’s picture

Title: Remove IE6-specific CSS » Remove IE6-specific code

Also contains Javascript.

jrabeemer’s picture

So I guess the proper way to test this patch is to test if IE6 breaks? LOL It sounds good to me either way. :)

cosmicdreams’s picture

I'll try to test this using IETester tonight http://www.my-debugbar.com/wiki/IETester/HomePage

cosmicdreams’s picture

I need to check the documentation for applying patches again. I can't seem to apply this one using git apply.

cosmicdreams’s picture

FileSize
29.41 KB

Here's a screenshot of my issue. Perhaps my true issue is that I'm trying to apply this patch using git for Windows.

cosmicdreams’s picture

Status: Needs review » Needs work

So... I can apply other patches using the methods I've described above but not this one. Can you reroll the patch casey?

seutje’s picture

@cosmicdreams: patch seems to lack prefix paths, just add -p0 to whatever ur using to apply it (ergo, "git apply -p0" || "patch -p0")

@casey: don't --no-prefix anymore, bot can handle prefixed patches and that's the standard now afaik

cosmicdreams’s picture

ah, ok, just like in the CVS age. (get it, like "Dark Age". )

cosmicdreams’s picture

ok, I got the patch to apply. I'll be able to test this out tomorrow.

I guess the test plan for this patch is to try out every page. right?

aspilicious’s picture

I think we should split this up in smaller pieces. Larg parts of this is also done in other theme specific patches. It's easier if we split it up, will be commited faster.

aspilicious’s picture

Status: Needs work » Closed (duplicate)

Srry but I'm going to close the duplicates because we are patching in 3 different places

#308865: Drop IE6 support in Drupal core