The code looks nice and clean. Any plans for a Drupal 7 version? I definitely would use this more simplified version over the other facebook tools.

I could even take a quick stab at it the initial port, if you didn't mind maintaining both branches :)

Comments

TripX’s picture

subscribe

this would be awesome

aidanlis’s picture

I don't think it will even need porting, just change the .info file and it should work in D7. I'll release a D7 version when I get some free time (not soon).

rickmanelius’s picture

2 changes required. First, the .info changes

name = Facebook pull
description = Fast and efficient module to pull from a facebook feed
core = 7.x
version = "7.x-1.0"


; Information added by drupal.org packaging script on 2011-06-07
version = "7.x-1.1"
core = "7.x"
project = "facebook_pull"

And also, hook theme goes from arguments to variables

/**
 * Implementation of hook_theme().
 */
function facebook_pull_theme($existing, $type, $theme, $path) {
  $theme = array(
    'facebook_pull_feed' => array(
      'variables' => array('items' => array()),
      'template'  => 'facebook_pull-feed',
    ),
  );
  return $theme;
}
Rechi’s picture

Didn't work for me completely.
The $items variable in the facebook_pull-feed.tpl.php doesn't get assigned correctly.
If I add

$items[0] = $variables[0];

in the facebook_pull-feed.tpl.php I get at least the first facebook post.

I also have the problem that with the generated https://graph.facebook.com/... call
I only get my first post (tried the generated link in the browser)

Drupal Core Verision 7.7

Rechi’s picture

Ok first problem solved:
change:
return theme('facebook_pull_feed', $data);

to
return theme('facebook_pull_feed',array('items' => $data));

Juan C’s picture

Subscribe

aidanlis’s picture

Status: Active » Fixed

Ported to D7!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.