Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
I'm using FullCalendar with Bartik theme and the text inside the buttons is not centred.
The cause is the CSS in the Bartik theme
td {text-align:left}
which needs to be overridden by FullCalendar to make the buttons appear correctly.
.fc-header td {text-align:center};
Comment | File | Size | Author |
---|---|---|---|
#9 | 1180936-fullcalendar_recommended_version.patch | 3.36 KB | amateescu |
#7 | 1180936-update_fullcalendar_plugin_version.patch | 776 bytes | amateescu |
#1 | fullcalendar-buttontextalign-1180936-2.patch | 656 bytes | Anonymous (not verified) |
left align.jpg | 31.89 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedPatch for above. I've replaced '.fcheader-title' with '.fcheader td' which now covers text align in buttons and title.
Comment #2
aspilicious CreditAttribution: aspilicious commentedIf you update your fullcalendar plugin to the newest version you don't have this problem anymore. He rewrote his css and now its fixed. It's up to Tim if he wants this to be changed. I guess it won't hurt.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedI am using the dev version of 3rd June and problem is there.
Comment #4
aspilicious CreditAttribution: aspilicious commentedThe *plugin* as not from drupal.org. The library found at this site http://arshaw.com/fullcalendar/
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedAhhh OK I see. The problem then is that I used "drush fullcalendar-plugin" and that's not pulling the latest release but 1.4.10
Comment #6
tim.plunkettSo we should also update the current version, so that drush will grab the newest one.
Comment #7
amateescu CreditAttribution: amateescu commentedHere's a patch for that :)
Comment #8
aspilicious CreditAttribution: aspilicious commentedamateescu this wont work because all the sites with 1.4.x version will get warnings. Hook_requirements calls _fullcalendar_status which tests for the version.
I think the best thing we can do is hardcode a version into drush and change it once in a while. Or make a new define only for that. But thats the same as hardcoding.
Comment #9
amateescu CreditAttribution: amateescu commentedYou're right. How about this one? I also added some requirements text and a static cache in
fullcalendar_get_version()
.Comment #10
aspilicious CreditAttribution: aspilicious commentedI like this :).
Comment #11
aspilicious CreditAttribution: aspilicious commentedamateescu while you're working with fullcalendar you maybe could look at #1156046: Add color support for Organic Groups ;)
Comment #12
amateescu CreditAttribution: amateescu commentedI'd be glad to, but I don't use OG in my current project and I see that patch is all about OG colours.. I dunno, maybe next week when I'll have some more free time :)
Comment #13
tim.plunkettThe diff-without-whitespace for the patch makes it even clearer. Awesome job, I'll probably just commit this now.
Comment #14
tim.plunkettThanks again!
http://drupalcode.org/project/fullcalendar.git/commit/aced77b